Populate testcase expand area on click

kiwitcms · Apr 29, 2020 · 5be30ab · 5be30ab
1 parent 7a97ed0
commit 5be30ab
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/tcms/testplans/static/testplans/js/get.js b/tcms/testplans/static/testplans/js/get.js
@@ -1,3 +1,5 @@
+var expandedTestCaseIds = [];
+
 $(document).ready(function() {
     const testPlanId = $('#test_plan_pk').data('testplanPk');
     const testCases = {
@@ -36,10 +38,10 @@ function drawTestCases(testCases, testPlanId, permissions) {
         testCaseRowDocumentFragment = $('#test_case_row')[0].content;
 
     if (Object.keys(testCases).length > 0) {
-       for (const testCaseId in testCases) {
+        for (const testCaseId in testCases) {
             container.append(getTestCaseRowContent(testCaseRowDocumentFragment.cloneNode(true), testCases[testCaseId], permissions));
         }
-        attachEvents(testPlanId, permissions);
+        attachEvents(testCases, testPlanId, permissions);
         if (permissions['perm-change-testcase']) {
             drawStatusAndPriority();
         }
@@ -48,7 +50,6 @@ function drawTestCases(testCases, testPlanId, permissions) {
     }
 }
 
-
 function getTestCaseRowContent(rowContent, testCase, permissions) {
     var row = $(rowContent);
 
@@ -77,8 +78,6 @@ function getTestCaseRowContent(rowContent, testCase, permissions) {
     );
     automation_indication_element.removeClass(automated_class_to_remove);
 
-    getTestCaseExpandArea(row, testCase);
-
     return row;
 }
 
@@ -118,7 +117,7 @@ function getTestCaseExpandArea(row, testCase) {
     });
 }
 
-function attachEvents(testPlanId, permissions) {
+function attachEvents(testCases, testPlanId, permissions) {
     if (permissions['perm-change-testcase']) {
         // update default tester
         $('.js-test-case-menu-tester').click(function(ev) {
@@ -162,8 +161,22 @@ function attachEvents(testPlanId, permissions) {
         });
     }
 
+    // get details and draw expand area only on expand
+    $('.js-testcase-row').click(function(ev) {
+        const testCaseId = getCaseIdFromEvent(ev);
+
+        // tc was expanded once, dom is ready
+        if (expandedTestCaseIds.indexOf(testCaseId) > -1) {
+            return;
+        }
+
+        const tcRow = $(ev.target).closest('.js-testcase-row');
+        expandedTestCaseIds.push(testCaseId);
+        getTestCaseExpandArea(tcRow, testCases[testCaseId]);
+    });
+
     function getCaseIdFromEvent(ev) {
-        return $(ev.target).closest('.list-group-item').data('testcase-pk');
+        return $(ev.target).closest('.js-testcase-row').data('testcase-pk');
     }
 }
 

diff --git a/tcms/testplans/templates/testplans/get.html b/tcms/testplans/templates/testplans/get.html
@@ -113,7 +113,7 @@ <h2 class="card-pf-title">
 </template>
 
 <template id="test_case_row">
-    <div class="list-group-item" data-testcase-pk="">
+    <div class="list-group-item js-testcase-row" data-testcase-pk="">
         <div class="list-group-item-header">
             <div class="list-view-pf-main-info">
                 <div class="list-view-pf-left">