Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Patternfly 4 #1323

Open
asankov opened this issue Jan 25, 2020 · 8 comments
Open

Migrate to Patternfly 4 #1323

asankov opened this issue Jan 25, 2020 · 8 comments

Comments

@asankov
Copy link
Member

asankov commented Jan 25, 2020

Patternfly 4 has been out for almost a year now, so I think it is a good idea to upgrade.

This could be helpful:
https://www.patternfly.org/v4/get-started/migrate

@asankov asankov added this to the patternfly-migration milestone Jan 25, 2020
@atodorov
Copy link
Member

@chetas411 not sure why your comments don't come up in GitHub. I've received notifications for them.

@chetas411
Copy link

Hi @atodorov , yeah I commented that I am interested in this issue

@chetas411
Copy link

Just to confirm what I read on GSoC 2021 page is that, now we need to migrate the UI to patternfly v4 using React ?

@chetas411
Copy link

@atodorov Can you provide the directories I should start to look up for this?

@atodorov
Copy link
Member

Hi @atodorov , yeah I commented that I am interested in this issue

Assigned to you.

Just to confirm what I read on GSoC 2021 page is that, now we need to migrate the UI to patternfly v4 using React ?

There are 2 parts to this issue:

  1. We're using Patternfly visual components with their HTML + CSS implementation. That needs to be migrated to v4 and the syntax/css file imports, etc adjusted where necessary. Pages like login & registration, dashboard, telemetry pages, maybe search pages are easier b/c there are less UI widgets inside of them. These need to be migrated one by one, ideally we can ship both v3 & v4 together for some time. If not we'll have to make all changes in a branch and merge in one huge PR.

  2. Patternfly (as in being a standard) has implementations in HTML+CSS, Angular and React. The testruns/get.html and testplans/get.html pages in particular keep a lot of internal state in their JavaScript code which makes them suitable for rewriting them with React. However this is secondary b/c these are very huge pages with tons of functionality and we're still uncertain how that could work. Thus the preference is that all pages will be migrated to Patternfly v4 in HTML+CSS implementation first and afterwards the most heavy pages will be reimplemented with Patternfly v4 in its React implementation.

If you'd like you can start working on item 1) and as we go along we'll figure out the process.

@chetas411
Copy link

Okay thanks I will be needing some time to get familiar with the codebase and then I will report you soon

@chetas411
Copy link

@atodorov Sorry I will not be able to do this issue.

@chetas411 chetas411 removed their assignment Feb 19, 2021
@atodorov atodorov added the UI/UX label Nov 10, 2022
@atodorov
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants