Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-menus and buttons should be links where appropriate #241

Closed
atodorov opened this issue Mar 1, 2018 · 0 comments
Closed

Sub-menus and buttons should be links where appropriate #241

atodorov opened this issue Mar 1, 2018 · 0 comments
Labels
refactoring UI/UX
Milestone
patternfly-migration

Comments

@atodorov
Copy link
Member

atodorov commented Mar 1, 2018

For TestPlan, TestCase and TestRun views many (all) of the sub-menu items and page buttons use JavaScript on click handlers to issue requests to the backend.

In some cases these are pure GET requests which can be handled directly via regular HTML links inside the template. No need for additional JavaScript.

This issue is to examine all of these buttons and sub-menus and figure out which of them can be refactored into links.
@atodorov atodorov added the UI/UX label Aug 2, 2018
@atodorov atodorov mentioned this issue Jan 6, 2020
Closed
@atodorov atodorov added this to the patternfly-migration milestone Jan 17, 2020
atodorov added a commit that referenced this issue Nov 8, 2020
@atodorov
Merge a left-over HTML template
8c68c6e 
there are no-more legacy run/ templates and the only one left
is merges inside its parent.

Closes #189 because there are no more `javascript:void` references
left in the code base.

Closes #241 because there are no more legacy buttons.
atodorov added a commit that referenced this issue Nov 9, 2020
@atodorov
Merge a left-over HTML template
e23c7fe 
there are no-more legacy run/ templates and the only one left
is merges inside its parent.

Closes #189 because there are no more `javascript:void` references
left in the code base.

Closes #241 because there are no more legacy buttons.
atodorov added a commit that referenced this issue Nov 20, 2020
@atodorov
Merge a left-over HTML template
1a66994 
there are no-more legacy run/ templates and the only one left
is merges inside its parent.

Closes #189 because there are no more `javascript:void` references
left in the code base.

Closes #241 because there are no more legacy buttons.
atodorov added a commit that referenced this issue Dec 1, 2020
@atodorov
Merge a left-over HTML template
d1bb9e6 
there are no-more legacy run/ templates and the only one left
is merges inside its parent.

Closes #189 because there are no more `javascript:void` references
left in the code base.

Closes #241 because there are no more legacy buttons.
asankov pushed a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
@atodorov @asankov
Merge a left-over HTML template
2a6edeb 
there are no-more legacy run/ templates and the only one left
is merges inside its parent.

Closes kiwitcms#189 because there are no more `javascript:void` references
left in the code base.

Closes kiwitcms#241 because there are no more legacy buttons.
asankov pushed a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
@atodorov @asankov
Merge a left-over HTML template
b52e269 
there are no-more legacy run/ templates and the only one left
is merges inside its parent.

Closes kiwitcms#189 because there are no more `javascript:void` references
left in the code base.

Closes kiwitcms#241 because there are no more legacy buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring UI/UX
Projects
None yet
Milestone
patternfly-migration
Development

No branches or pull requests
1 participant
@atodorov