If JIRA isn't fully configured then don't connect. Fixes #100 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out the underlying jira library tries to connect automatically when a jira.JIRA object is created. When the Issue Tracker is not fully configured (i.e. missing base_url, api_url, api_username, api_password) then the library will default to localhost and fail to connect to the JIRA server. This causes the TestRun report view to timeout and fail. This commit adds tests for all supported issue trackers and also fixes the JIRA implementation to not connect if not configured.
Pull Request Test Coverage Report for Build 337
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GotfatherThe turns out the underlying jira library tries to connect
automatically when a jira.JIRA object is created. When the
Issue Tracker is not fully configured (i.e. missing base_url,
api_url, api_username, api_password) then the library will default
to localhost and fail to connect to the JIRA server.
This causes the TestRun report view to timeout and fail.
This commit adds tests for all supported issue trackers and also
fixes the JIRA implementation to not connect if not configured.