Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Issue Tracker connections per base_url. Fixes #290 #1093

Merged
merged 1 commit into from Sep 2, 2019

Conversation

atodorov
Copy link
Member

@atodorov atodorov commented Sep 2, 2019

in this way we create object to connect to the remote end only
once, which should improve speed of work when working often with
bugs directly from Kiwi TCMS. This also makes it possible to
still have multiple IT integrations in the same instance b/c they
will have unique base URLs.

in this way we create object to connect to the remote end only
once, which should improve speed of work when working often with
bugs directly from Kiwi TCMS. This also makes it possible to
still have multiple IT integrations in the same instance b/c they
will have unique base URLs.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3850

  • 9 of 21 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 73.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tcms/issuetracker/types.py 9 21 42.86%
Totals Coverage Status
Change from base Build 3786: 0.08%
Covered Lines: 3580
Relevant Lines: 4603

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #1093 into remove_bug_use_linkreference will increase coverage by 0.06%.
The diff coverage is 42.85%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           remove_bug_use_linkreference    #1093      +/-   ##
================================================================
+ Coverage                         73.06%   73.12%   +0.06%     
================================================================
  Files                               111      111              
  Lines                              4603     4603              
  Branches                            591      590       -1     
================================================================
+ Hits                               3363     3366       +3     
+ Misses                             1026     1022       -4     
- Partials                            214      215       +1
Impacted Files Coverage Δ
tcms/issuetracker/types.py 32.16% <42.85%> (+1.75%) ⬆️
tcms/core/history.py 90.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545c6b0...d853442. Read the comment docs.

@atodorov atodorov merged commit 8de72a9 into remove_bug_use_linkreference Sep 2, 2019
@atodorov atodorov deleted the cache_rpc_connection branch September 2, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants