New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
l10n updates #1116
Merged
Merged
l10n updates #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
atodorov
commented
Sep 11, 2019
- refreshed strings b/c formatting
- updates that will help enable in-context translations
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
======================================
Coverage 72% 72%
======================================
Files 111 111
Lines 4850 4850
Branches 622 622
======================================
Hits 3492 3492
+ Misses 1136 1135 -1
- Partials 222 223 +1
Continue to review full report at Codecov.
|
atodorov
force-pushed
the
l10n_addons
branch
from
September 11, 2019 18:31
349a0b1
to
e700295
Compare
Crowdin in-context translation for Esperanto uses automatic msgstr which don't have these characters. This in turn causes compilemessages to fail! Note: this is mostly an issue where we use blocktrans and multi-line strings. The solution is to make them look uglier :-(. In the final HTML/email they will be displayed the same.
b/c updated in French translation later. Note: the actual French string is "L'utilisateur saisi n'existe pas en base" where the apostrophes get rendered as ' in HTML and although the result is translated the assertion fails. As a workaround we'll not merge the commit introducing this string ATM. CC @RMadjev
this is leftover from a recent PR CC @RMadjev
atodorov
force-pushed
the
l10n_addons
branch
from
September 11, 2019 19:28
e700295
to
50bb83b
Compare
Pull Request Test Coverage Report for Build 4102
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4106
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4100
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.