Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n updates #1116

Merged
merged 48 commits into from Sep 11, 2019
Merged

l10n updates #1116

merged 48 commits into from Sep 11, 2019

Conversation

atodorov
Copy link
Member

  • refreshed strings b/c formatting
  • updates that will help enable in-context translations

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1116   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files         111     111           
  Lines        4850    4850           
  Branches      622     622           
======================================
  Hits         3492    3492           
+ Misses       1136    1135    -1     
- Partials      222     223    +1
Impacted Files Coverage Δ
tcms/testcases/forms.py 81.14% <ø> (ø) ⬆️
tcms/core/history.py 90.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b103655...50bb83b. Read the comment docs.

Crowdin in-context translation for Esperanto uses automatic msgstr
which don't have these characters. This in turn causes
compilemessages to fail!

Note: this is mostly an issue where we use blocktrans and multi-line
strings. The solution is to make them look uglier :-(. In the final
HTML/email they will be displayed the same.
b/c updated in French translation later.

Note: the actual French string is
"L'utilisateur saisi n'existe pas en base" where the
apostrophes get rendered as &#39; in HTML and although the result
is translated the assertion fails.

As a workaround we'll not merge the commit introducing this
string ATM.

CC @RMadjev
this is leftover from a recent PR

CC @RMadjev
@atodorov atodorov merged commit 7db9497 into master Sep 11, 2019
@atodorov atodorov deleted the l10n_addons branch September 11, 2019 20:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4102

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.458%

Totals Coverage Status
Change from base Build 4043: 0.0%
Covered Lines: 3714
Relevant Lines: 4850

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4106

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 72.445%

Totals Coverage Status
Change from base Build 4043: -0.01%
Covered Lines: 3713
Relevant Lines: 4849

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4100

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.458%

Totals Coverage Status
Change from base Build 4043: 0.0%
Covered Lines: 3714
Relevant Lines: 4850

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants