Test run patternfly status bar - Obsoletes #1436 #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes HTML mangling inside JavaScript
- can't have <li> elements outside of <ul> - spacing between label & number was missing - inconsistent with the labels above - point the URL explicitly to the current TR instead of using '#' Note: when using '#' for the URL and filtering by status the resulting URL was '/runs/123/?status_id=x#', now it is '/runs/123/'!
asankov
reviewed
Apr 15, 2020
| @@ -131,6 +131,11 @@ class GetTestRunView(DetailView): # pylint: disable=missing-permission-required | |||
| model = TestRun | |||
| response_class = ModifySettingsTemplateResponse | |||
|
|
|||
| def get_context_data(self, **kwargs): | |||
Codecov Report
@@ Coverage Diff @@
## refactor_testrun_ui #1544 +/- ##
=======================================================
+ Coverage 76.11% 76.13% +0.02%
=======================================================
Files 122 122
Lines 4384 4388 +4
Branches 510 510
=======================================================
+ Hits 3337 3341 +4
Misses 875 875
Partials 172 172
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes #1436 rebases it to the latest upstream and adjusts HTML & JavaScript.