New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add management command to change Kiwi TCMS domain #1587

Merged

atodorov merged 1 commit into kiwitcms:master from schwarzkrieger:issue-971

May 14, 2020

Contributor

schwarzkrieger commented Apr 28, 2020 •

edited

Loading

Closes #971.

If you like it I'll write some tests.

schwarzkrieger changed the title ~~Add management command to change Base URL. Closes #971~~ Add management command to change Base URL.Closes #971

schwarzkrieger changed the title ~~Add management command to change Base URL.Closes #971~~ Add management command to change Base URL. Closes #971

schwarzkrieger force-pushed the issue-971 branch from bcacfe9 to 8136607 Compare

April 28, 2020 08:41

codecov bot commented Apr 28, 2020 •

edited

Loading

Codecov Report

Merging #1587 into master will increase coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
+ Coverage   76.29%   76.81%   +0.52%     
==========================================
  Files         119      120       +1     
  Lines        4357     4343      -14     
  Branches      498      494       -4     
==========================================
+ Hits         3324     3336      +12     
+ Misses        869      844      -25     
+ Partials      164      163       -1

Impacted Files	Coverage Δ
tcms/core/management/commands/set_domain.py	`100.00% <100.00%> (ø)`
tcms/rpc/api/testexecution.py	`73.49% <0.00%> (-4.14%)`	⬇️
tcms/testcases/models.py	`76.35% <0.00%> (-1.91%)`	⬇️
tcms/testruns/views.py	`78.96% <0.00%> (-0.59%)`	⬇️
tcms/rpc/api/forms/testrun.py	`86.27% <0.00%> (+0.27%)`	⬆️
tcms/testcases/views.py	`73.70% <0.00%> (+4.40%)`	⬆️
tcms/testplans/models.py	`97.59% <0.00%> (+12.29%)`	⬆️
tcms/core/forms/fields.py	`100.00% <0.00%> (+15.38%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f82e8c...ef9537b. Read the comment docs.

schwarzkrieger changed the title ~~Add management command to change Base URL. Closes #971~~ Add management command to change Base URL.

atodorov requested changes

View reviewed changes

Member

atodorov left a comment

Overall looks good.

Needs more work
Needs tests
Needs update to documentation

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

atodorov requested changes

View reviewed changes

Member

atodorov left a comment

Needs tests
Needs update to documentation

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

atodorov mentioned this pull request

Couple of bug fixes #1640

Merged

atodorov reviewed

View reviewed changes

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

atodorov requested changes

View reviewed changes

Member

atodorov left a comment

still todo

schwarzkrieger force-pushed the issue-971 branch from 16d68fc to 092c3ae Compare

May 7, 2020 21:50

atodorov requested changes

View reviewed changes

Member

atodorov left a comment

Needs changes, you can squash all commits together

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/tests/factories.py Outdated Show resolved Hide resolved

tcms/management/tests/test_baseurl.py Outdated Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

tcms/management/tests/test_baseurl.py Outdated Show resolved Hide resolved

docs/source/admin.rst Show resolved Hide resolved

tcms/management/management/commands/baseurl.py Outdated Show resolved Hide resolved

schwarzkrieger force-pushed the issue-971 branch from 092c3ae to d81559d Compare

May 10, 2020 10:19

atodorov requested changes

View reviewed changes

Member

atodorov left a comment

Looks better now but still needs adjustments to naming and commit log.

Note: the URL for this section in the docs is also used in middleware which tells the when this isn't configured!

tcms/core/tests/test_baseurl.py Outdated Show resolved Hide resolved

tcms/core/tests/test_baseurl.py Outdated Show resolved Hide resolved

tcms/core/tests/test_baseurl.py Outdated Show resolved Hide resolved

docs/source/installing_docker.rst Outdated Show resolved Hide resolved

docs/source/installing_docker.rst Outdated Show resolved Hide resolved

tcms/core/management/commands/baseurl.py Outdated Show resolved Hide resolved

atodorov requested changes

View reviewed changes

docs/source/installing_docker.rst Outdated Show resolved Hide resolved

schwarzkrieger force-pushed the issue-971 branch from d81559d to 79bb884 Compare

May 12, 2020 21:14

atodorov requested changes

View reviewed changes

docs/source/installing_docker.rst Outdated Show resolved Hide resolved

docs/source/installing_docker.rst Outdated Show resolved Hide resolved


          Add management command to change Kiwi TCMS domain

ef9537b

Closes kiwitcms#971

schwarzkrieger changed the title ~~Add management command to change Base URL.~~ Add management command to change Kiwi TCMS domain

schwarzkrieger force-pushed the issue-971 branch from 79bb884 to ef9537b Compare

May 13, 2020 18:03

atodorov approved these changes

View reviewed changes

atodorov merged commit 463bc83 into kiwitcms:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment