Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing with the internal bug tracker disabled. Refs #1370 #1633

Merged
merged 4 commits into from May 1, 2020

Conversation

atodorov
Copy link
Member

  • all tests should be passign with and without this App
  • specific tcms.bugs related tests should be skipped when the
    App is not found in INSTALLED_APPS

- all tests should be passing with and without this App
- specific tcms.bugs related tests should be skipped when the
  App is not found in INSTALLED_APPS
- don't share BugFactory with the rest of the project
- conditionally skip tcms.bugs.tests modules
- ignore flake8's `E402 module level import not at top of file`
- ignore pylint's wrong-import-position
- conditionally assert expected results
@atodorov atodorov force-pushed the disable_internal_bugtracker branch from 2054ae1 to 99fe3db Compare April 30, 2020 21:21
@atodorov atodorov marked this pull request as ready for review April 30, 2020 21:21
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1633 into master will increase coverage by 0.06%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
+ Coverage   76.51%   76.57%   +0.06%     
==========================================
  Files         123      124       +1     
  Lines        4564     4590      +26     
  Branches      545      550       +5     
==========================================
+ Hits         3492     3515      +23     
+ Misses        900      899       -1     
- Partials      172      176       +4     
Impacted Files Coverage Δ
tcms/tests/factories.py 86.22% <ø> (-0.61%) ⬇️
tcms/rpc/api/testexecution.py 77.63% <40.00%> (-2.93%) ⬇️
tcms/issuetracker/types.py 28.77% <50.00%> (-0.21%) ⬇️
tcms/settings/common.py 95.52% <66.66%> (-1.41%) ⬇️
tcms/urls.py 74.28% <66.66%> (-1.48%) ⬇️
tcms/bugs/tests/factory.py 100.00% <100.00%> (ø)
tcms/management/models.py 97.05% <0.00%> (+3.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b42be...99fe3db. Read the comment docs.

@atodorov atodorov merged commit d866f8c into master May 1, 2020
@atodorov atodorov deleted the disable_internal_bugtracker branch May 1, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant