Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract bugs table into reusable template #1718

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

asankov
Copy link
Member

@asankov asankov commented May 30, 2020

this template will be plugged into every test execution row in the test run page

@asankov asankov self-assigned this May 30, 2020
tcms/templates/include/bugs_table.html Outdated Show resolved Hide resolved
tcms/templates/include/bugs_table.html Outdated Show resolved Hide resolved
tcms/templates/include/bugs_table.html Outdated Show resolved Hide resolved
tcms/static/js/bugs.js Outdated Show resolved Hide resolved
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested and should be ready to go.

tcms/templates/include/bugs_table.html Outdated Show resolved Hide resolved
tcms/templates/include/bugs_table.html Outdated Show resolved Hide resolved
@asankov asankov force-pushed the bugs-table branch 3 times, most recently from f007fca to c713361 Compare June 15, 2020 12:07
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, minor comments

tcms/templates/include/bugs_table.html Outdated Show resolved Hide resolved
tcms/static/js/bugs.js Outdated Show resolved Hide resolved
dom: "t",
language: {
loadingRecords: '<div class="spinner spinner-lg"></div>',
processing: '<div class="spinner spinner-lg"></div>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comments for these as well but that can be left for later.

@atodorov atodorov merged commit 188b0db into kiwitcms:refactor_testrun_ui Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants