Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint checker class to check for ModelForm inheritance #1744

Merged
merged 1 commit into from Jun 19, 2020

Conversation

brymut
Copy link
Contributor

@brymut brymut commented Jun 17, 2020

Resolves #1384. Add a lint checker class to check if all forms inherit from ModelForm.

kiwi_lint/model_form.py Outdated Show resolved Hide resolved
kiwi_lint/model_form.py Outdated Show resolved Hide resolved
kiwi_lint/model_form.py Outdated Show resolved Hide resolved
@brymut brymut force-pushed the inherit-modelform-checker branch from ade3a4a to 9d33eb2 Compare June 18, 2020 12:31
@brymut brymut requested a review from atodorov June 19, 2020 08:52
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor changes requested.

Once you rebase this should be ready for merge.

kiwi_lint/__init__.py Show resolved Hide resolved
kiwi_lint/forms.py Outdated Show resolved Hide resolved
kiwi_lint/forms.py Outdated Show resolved Hide resolved
@brymut brymut force-pushed the inherit-modelform-checker branch from 9d33eb2 to fb9a7e7 Compare June 19, 2020 15:29
@atodorov atodorov merged commit 4570c70 into kiwitcms:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new linter: All forms must inherit from ModelForm
2 participants