[TestRuns] Fix removeCases function
#3282
Conversation
- delete all TEs related to TCs
| .data('test-execution-id') | ||
| ) | ||
| } | ||
| ) |
There was a problem hiding this comment.
This is definitely wrong and has been wrong from the very beginning. When you select test executions and delete them the expected behavior is that only items which are selected will be deleted, not everything else related to the same test case.
IMO fixing the problem will require a few more steps, probably best to be done separately.
-
Copy
TestRun.remove_case()API method under a new nameTestRun.remove_executionand modify it to accept a dictionary (see methods which acceptvaluesparameters). That will needs some tests. -
Adjust the UI and replace
TestRun.remove_casewithTestRun.remove_executionin all places where it is used, leaving the.remove_case()method to be used by external API consumers until it is removed. -
Come back to this PR and adjust as needed in order to allow adding parametrized test case variants for executions which have been previously removed! (if that is desired).
There was a problem hiding this comment.
I'm actually OK with this behavior, but I understand what you mean :)
At the moment I don't have time for that.
instead of removing all of them. Adjusts internal state accordingly. Add deprecation warning for API method TestRun.remove_case()
instead of removing all of them. Adjusts internal state accordingly. Add deprecation warning for API method TestRun.remove_case()
There are cases when several TEs are created from single TC (when TC is parametrized):
removeCasesfunction intcms/testruns/static/testruns/js/get.jsdoes not take it into account.As a result, it is not possible to re-add the same test case without reloading the page. Also, the counter shows the wrong number.
See video with defect:
https://i.imgur.com/NxqHDq1.mp4