Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Plan -> Runs to jsonrpc and datatables #499

Merged
merged 3 commits into from Aug 30, 2018
Merged

Convert Plan -> Runs to jsonrpc and datatables #499

merged 3 commits into from Aug 30, 2018

Conversation

atodorov
Copy link
Member

No description provided.

@atodorov
Re-use TestRuns search page for TestPlan -> Runs. Refs #104
062d8fb 
- remove unnecessary view and templates

Note: for the moment we're going to use an iframe until we
      figure out how to re-use Patternfly components
@atodorov
Consolidate duplicate JavaScript into updateParamsToSearchTags()
3149878
@atodorov
Escape HTML in texts shown in DataTables
ca3e119
@coveralls
Copy link

coveralls commented Aug 30, 2018 •
edited

Pull Request Test Coverage Report for Build 1545

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 62.91%
Totals Coverage Status
Change from base Build 1536: -0.3%
Covered Lines: 4752
Relevant Lines: 7028
💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Aug 30, 2018 •
edited

Codecov Report

Merging #499 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   63.69%   63.46%   -0.24%     
==========================================
  Files         115      115              
  Lines        7081     7028      -53     
  Branches     1009     1000       -9     
==========================================
- Hits         4510     4460      -50     
+ Misses       2273     2272       -1     
+ Partials      298      296       -2
Impacted Files Coverage Δ
tcms/testruns/forms.py 79.38% <ø> (-2.36%) ⬇️
tcms/testruns/views.py 67.15% <ø> (-1.79%) ⬇️
tcms/testplans/urls/plan_urls.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72613b...ca3e119. Read the comment docs.

@atodorov atodorov merged commit f3a49f3 into master Aug 30, 2018
@atodorov atodorov deleted the convert_plan_runs_to_jsonrpc_and_datatables branch August 30, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atodorov @coveralls @codecov-io