Fix crash with kc users #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
fix_crash_with_kc_users
branch
4 times, most recently
from
3f5fd30
to
65c3f15
Compare
for Keycloak the uid field is the string username in Keycloak, not a number so don't crash. Fixes KIWI-TCMS-GM, see https://sentry.io/organizations/kiwitcms/issues/2468613371
- we need tcms/tests/ for factories inside tcms_tenants.tests - see 041a3aa9 in kiwitcms/tenants WARNING: pwd should be last in sys.path b/c it causes the settings override code to try and import from ./tcms_settings_dir/ which is empty and multi-tenant settings don't get loaded!
also install Kiwi TCMS requirements b/c pylint will complain about missing imoports
atodorov
force-pushed
the
fix_crash_with_kc_users
branch
10 times, most recently
from
3048a68
to
88cbbb2
Compare
atodorov
force-pushed
the
fix_crash_with_kc_users
branch
from
431f7a6
to
06bdf60
Compare
atodorov
force-pushed
the
fix_crash_with_kc_users
branch
from
06bdf60
to
01c1f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.