Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub exception #57

Merged
merged 3 commits into from Jan 31, 2022
Merged

Fix GitHub exception #57

merged 3 commits into from Jan 31, 2022

Conversation

atodorov
Copy link
Member

No description provided.

@atodorov
ci: Add missing KIWI_TENANTS_DOMAIN variable
0b22d4c
@atodorov
Raise GitHub exceptions differently
d7f3cdd 
for some reason importing the child module and raising exceptions from
it doesn't work:

AttributeError: type object 'GithubException' has no attribute 'UnknownObjectException'

but when raising the exceptions with the `github.` module prefix it
works.

Fixes KIWI-TCMS-HH,
https://sentry.io/organizations/kiwitcms/issues/2959079667
@atodorov
Changelog for v1.3.3
5336119
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.785% when pulling 5336119 on fix_github_exception into c554621 on master.

@atodorov atodorov merged commit cb94c7b into master Jan 31, 2022
@atodorov atodorov deleted the fix_github_exception branch January 31, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atodorov @coveralls