Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require kiwitcms-tenants>=1.5 #41

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Require kiwitcms-tenants>=1.5 #41

merged 7 commits into from
Jun 10, 2021

Conversation

atodorov
Copy link
Member

@atodorov atodorov commented Jun 4, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jun 4, 2021

This pull request fixes 1 alert when merging 01e0db0 into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@atodorov atodorov force-pushed the latest_tenants branch 2 times, most recently from 4f2e09c to a16f6f4 Compare June 9, 2021 11:50
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request fixes 1 alert when merging 1c45e6e into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request fixes 1 alert when merging 391bb38 into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request fixes 1 alert when merging 35a673f into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@atodorov atodorov force-pushed the latest_tenants branch 2 times, most recently from f73dd30 to 4d009bf Compare June 9, 2021 12:45
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request fixes 1 alert when merging 4d009bf into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@atodorov atodorov force-pushed the latest_tenants branch 4 times, most recently from 00aa49d to a41720d Compare June 9, 2021 13:15
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request fixes 1 alert when merging e7e4d08 into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request fixes 1 alert when merging ad9cf2f into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

- we need tcms/tests/ for factories inside tcms_tenants.tests
- see 041a3aa9 in kiwitcms/tenants

WARNING: pwd should be last in sys.path b/c it causes the settings
override code to try and import from ./tcms_settings_dir/ which is
empty and multi-tenant settings don't get loaded!
also install Kiwi TCMS requirements b/c pylint will complain about
missing imoports
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request fixes 1 alert when merging eb27679 into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request fixes 1 alert when merging 180258c into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

now that its parent is a FormView split the form initialization into
more granular methods.

Add more assertions into tests.
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request fixes 1 alert when merging 344d6d4 into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request fixes 1 alert when merging cbbe6f3 into 7f483e7 - view on LGTM.com

fixed alerts:

  • 1 for First argument to super() is not enclosing class

@atodorov atodorov merged commit e3fa459 into master Jun 10, 2021
@atodorov atodorov deleted the latest_tenants branch June 10, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant