Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix Desktop 2.0.4 always quits with segfault on Ubuntu 18.04 #423

Closed
kelson42 opened this issue Apr 21, 2020 · 7 comments
Closed

Kiwix Desktop 2.0.4 always quits with segfault on Ubuntu 18.04 #423

kelson42 opened this issue Apr 21, 2020 · 7 comments

Comments

@kelson42
Copy link
Collaborator

$ ./kiwix-desktop_x86_64.appimage 
Library directory : "/tmp"
Compiled with Qt Version  5.9.5
Runtime Qt Version  5.9.5
add widget
session saved
Segmentation fault (core dumped)
@kelson42
Copy link
Collaborator Author

kelson42 commented Apr 21, 2020

Maybe related to #123?
Maybe related to #393?

@stale
Copy link

stale bot commented Jun 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 20, 2020
@kelson42
Copy link
Collaborator Author

kelson42 commented Jul 2, 2020

I don't have this behaviour with 20.04 and https://download.kiwix.org/release/kiwix-desktop/kiwix-desktop_x86_64_2.0.3.appimage. Closing the issue.

@kelson42 kelson42 closed this as completed Jul 2, 2020
@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 5, 2020

Reopening the issue, because it happens again with Ubuntu 20.04 and the Debian package in our PPA:

$ kiwix-desktop 
Library directory : "/home/kelson/.local/share/kiwix"
Compiled with Qt Version  5.12.8
Runtime Qt Version  5.12.8
aria2 tellActive failed : Invalid return code from ariaaria2 tellWaiting failed : Invalid return code from ariaadd widget
terminate called after throwing an instance of 'std::runtime_error'
  what():  Invalid return code from aria
Aborted (core dumped)

But it works with the latest appimage https://download.kiwix.org/release/kiwix-desktop/kiwix-desktop_x86_64_2.0.4.appimage

@kelson42 kelson42 reopened this Aug 5, 2020
@stale stale bot removed the stale label Aug 5, 2020
@kelson42 kelson42 changed the title Kiwix Desktop 2.0.1-1 appimage always quits with segfault on Ubuntu 18.04 Kiwix Desktop 2.0.4 always quits with segfault on Ubuntu 18.04 Aug 5, 2020
@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 5, 2020

@mgautierfr This might be related to Qt as the appimage uses Qt 5.9 and the deb package 5.12.

@mgautierfr
Copy link
Member

aria2 tellActive failed : Invalid return code from ariaaria2 tellWaiting failed : Invalid return code from ariaadd widget
terminate called after throwing an instance of 'std::runtime_error'
what(): Invalid return code from aria

It is probably a problem with aria interaction and the debian packaging.

mgautierfr added a commit to kiwix/libkiwix that referenced this issue Aug 25, 2020
WaitingThread read some shared memory with the SubProcess
(`mutex`, `m_running`).
When we destroy the SubProcess, we must be sure that WaitingThread has
correctly finished else we may have invalid read/write on freed memory.

May fix kiwix/kiwix-desktop#123, kiwix/kiwix-desktop#513
and kiwix/kiwix-desktop#423
mgautierfr added a commit to kiwix/libkiwix that referenced this issue Aug 26, 2020
Use a heap allocated buffer (with lifetime of Aria2 class) instead of
a stack allocated one.

Fix #kiwix/kiwix-desktop#123, kiwix/kiwix-desktop#513
and kiwix/kiwix-desktop#423
mgautierfr added a commit to kiwix/libkiwix that referenced this issue Aug 26, 2020
Use a heap allocated buffer (with lifetime of Aria2 class) instead of
a stack allocated one.

Original fix made by @ZaWertun. Kudos to him.

Fix #kiwix/kiwix-desktop#123, kiwix/kiwix-desktop#513
and kiwix/kiwix-desktop#423
@kelson42
Copy link
Collaborator Author

Probably a duplicate of #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants