Fix contentmanager/mainWindow initialisation on windows. #783
Conversation
`windowHandle` return a valid value only if the widget has been shown. So we must use it *after* it is shown, not at the end of its construction. This subtle change also avoid a early return in the MainWindow constructor and so, we correctly configure the mainWindow on Windows. The last configuration is setting the content manager of the content manager side. If this is skip, kiwix-desktop crash as soon as we click on "All files" as we use a uninitialized pointer.
|
@mgautierfr Thank you very much for the PR |
|
Works good on my side (also fixes the side filter panel showing up in Settings) |
|
Late to the party but works for me. The library, however, did not load up any files but I don't know if that is bug or feature. |
|
It should |
|
Well then we have a new problem. |
|
Just a hunch but maybe its a language filter issue? Browse by language -> All, if that shows |
|
Nope. Tested on 2.0.5 and it's not working either (pretty sure it did before). My internet works, got no filter or weird settings. Will test in a couple of hours on another PC on another network. |
But it has a test if the native window is null and return if yes. This is somehow buggy as the native window exists only if the widget has been shown and it is not the case.
setContentManageradd the end of the previous code. On windows it was never called and as soon as we try to use it (by clicking on "All files" (https://github.com/kiwix/kiwix-desktop/blob/master/src/contentmanagerside.cpp#L16)) kiwix-desktop crash.This PR "simply" move the configuration of the fullscreen border at the correct position (after the widget is shown) and remove the early exit in the constructor. Every thing is configured correctly.
A build of this PR is available here : http://tmp.kiwix.org/ci/fix_windows_contentmanager/kiwix-desktop_windows_x64_2022-02-07.zip
Fix #775