Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contentmanager/mainWindow initialisation on windows. #783

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix contentmanager/mainWindow initialisation on windows. #783

merged 1 commit into from
Feb 8, 2022

Commits on Feb 7, 2022

  1. Set the fullscreen border after the windows is shown. 

    `windowHandle` return a valid value only if the widget has been shown.
So we must use it *after* it is shown, not at the end of its construction.

This subtle change also avoid a early return in the MainWindow constructor
and so, we correctly configure the mainWindow on Windows.
The last configuration is setting the content manager of the content manager
side. If this is skip, kiwix-desktop crash as soon as we click on "All files"
as we use a uninitialized pointer.
    @mgautierfr
    mgautierfr committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    5b49480 View commit details
    Browse the repository at this point in the history