Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup for Tab transition animation #1101

Closed
Rishabhg71 opened this issue Sep 7, 2023 · 4 comments · Fixed by #1102
Closed

Code cleanup for Tab transition animation #1101

Rishabhg71 opened this issue Sep 7, 2023 · 4 comments · Fixed by #1102
Assignees
@Rishabhg71
Labels
cleanup duplicate remove-jquery Issues or PRs involving removal of jQuery

Comments

@Rishabhg71
Copy link
Collaborator

While working on issue #846 Adding a new tab seems more complex than expected code seems really confusing and there is a lot of repetition for the same function
check out
https://github.com/kiwix/kiwix-js/blob/main/www/js/lib/uiUtil.js#L490
@Rishabhg71 Rishabhg71 self-assigned this Sep 7, 2023
@Rishabhg71 Rishabhg71 added cleanup remove-jquery Issues or PRs involving removal of jQuery labels Sep 7, 2023
@Rishabhg71 Rishabhg71 mentioned this issue Sep 7, 2023
Merged
@Jaifroid
Copy link
Member

Jaifroid commented Sep 7, 2023

Thanks! This is probably a duplicate of #78? Or at least, it might also close #78.

@Jaifroid
Copy link
Member

Jaifroid commented Sep 7, 2023

Also see #701.

@Jaifroid
Copy link
Member

Jaifroid commented Sep 9, 2023

Closing as duplicate. Please add any discussion in #78.

@Jaifroid Jaifroid closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2023
@Jaifroid
Copy link
Member

Jaifroid commented Sep 9, 2023

Or add discussion to #701 if more appropriate.

Rishabhg71 added a commit that referenced this issue Sep 19, 2023
@Rishabhg71
Transition animation cleanup and page animation turned off by default #…
69f8554 
…78 and #1101 (#1102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rishabhg71 Rishabhg71

Labels
cleanup duplicate remove-jquery Issues or PRs involving removal of jQuery
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transition animation cleanup and page animation turned off by default Rishabhg71/kiwix-js
2 participants
@Jaifroid @Rishabhg71