Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a fancy library #846

Closed
kelson42 opened this issue Feb 13, 2022 · 8 comments · Fixed by #1127
Closed

Have a fancy library #846

kelson42 opened this issue Feb 13, 2022 · 8 comments · Fixed by #1127

Comments

@kelson42
Copy link
Collaborator

Now that we have a nice looking https://library.kiwix.org with and OPDS API. I would propose that Kiwix JS provides a nicer solution to download ZIM files. Maybe just load https://library.kiwix.org for example?

@kelson42 kelson42 transferred this issue from kiwix/kiwix-tools Mar 2, 2022
@mossroy
Copy link
Contributor

mossroy commented Mar 2, 2022

Maybe just load https://library.kiwix.org for example?

I don't see what you mean by that.

Is this a duplicate of #114 ?

So far, we did not implement anything to download ZIM files in kiwix-js, but @Jaifroid did in kiwix-js-windows. I suppose you mean his implementation could now be improved with OPDS?

@kelson42
Copy link
Collaborator Author

kelson42 commented Mar 2, 2022

@mossroy I don't know how the final solution should look like... but AFAIK everything is there now to avoid using https://download.kiwix.org.

@Jaifroid
Copy link
Member

Jaifroid commented Mar 2, 2022

I think we should develop a modern version here in Kiwix JS using the new system, and then I could backport it to Kiwix JS Windows. The implementation I have in KJSW is currently very different. It's fast and gets the job done (offers mirrors and torrent files), but it is text-based, not so pretty.

@Jaifroid
Copy link
Member

Jaifroid commented Jun 12, 2022

JFYI I now offer a link to preview the chosen ZIM on library.kiwix.org in the download UI in KJSW. This is an interim measure.

A simple option to trial here would be to load library.kiwix.org in an iframe when the user requests opening the Archive Library in-app. That would "just work" I think. Would we want something more complex, i.e. using OPDS ourselves and offering a slimmed-down UI?

I don't think we need to manage downloads ourselves, as browsers all have their own sophisticated code for doing this, and nothing we could do would have the same level of FS access (only in Chromium browsers could we use the File System Access API).

@Jaifroid
Copy link
Member

PS Advantage of using browser to manage downloads is that downloads can continue in the background even if the app is closed.

@kelson42
Copy link
Collaborator Author

BTW you might be interested in this new feature to be developed this summer kiwix/libkiwix#585

@kelson42
Copy link
Collaborator Author

kelson42 commented Jan 9, 2023

Highly related to #489, to do this ticket either getting OPDS and building UI locally or just getting the HTML directly from library.kiwix.org.

@Jaifroid
Copy link
Member

Jaifroid commented Jan 9, 2023

My comment #846 (comment) is still my opinion. This wouldn't be hard, just needs.... free time!

@Jaifroid Jaifroid modified the milestones: v3.8, v3.9 Apr 22, 2023
@Jaifroid Jaifroid assigned Rishabhg71 and unassigned Jaifroid Sep 5, 2023
Rishabhg71 added a commit that referenced this issue Oct 9, 2023
Added in-app support to download/browse Zim files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants