Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG for v3.11.0 #1145

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Update CHANGELOG for v3.11.0 #1145

merged 6 commits into from
Nov 12, 2023

Conversation

Jaifroid
Copy link
Member

@Jaifroid Jaifroid commented Nov 2, 2023

Please check that everything is included and clearly expressed.

@Jaifroid Jaifroid self-assigned this Nov 2, 2023
@Jaifroid Jaifroid added this to the v3.11 milestone Nov 2, 2023
Jaifroid
Jaifroid commented Nov 2, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Jaifroid
Copy link
Member Author

@Rishabhg71 Could you check this PR and if you're happy with the way the changes are described, please approve it. Could you also look at https://github.com/kiwix/kiwix-js/releases/tag/untagged-ef84b2b3e3e992cd2c1a (but don't publish it yet!) to see if it also looks OK? Those detailed notes are more or less auto-generated.

@Jaifroid
Copy link
Member Author

By the way, the linux BrowserStack tests keep falling over....

@Rishabhg71
Copy link
Collaborator

@Rishabhg71 Could you check this PR and if you're happy with the way the changes are described, please approve it. Could you also look at https://github.com/kiwix/kiwix-js/releases/tag/untagged-ef84b2b3e3e992cd2c1a (but don't publish it yet!) to see if it also looks OK? Those detailed notes are more or less auto-generated.

This looks good

By the way, the linux BrowserStack tests keep falling over....

Weird as it passed on my PRs but if it continues I will check these tests again

@Jaifroid Jaifroid merged commit 917dac8 into main Nov 12, 2023
8 of 9 checks passed
@Jaifroid Jaifroid deleted the Update-CHANGELOG-for-v3.11.0 branch November 12, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rishabhg71 Rishabhg71 Awaiting requested review from Rishabhg71

Assignees

@Jaifroid Jaifroid

Labels
information
Projects
None yet
Milestone
v3.11
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaifroid @Rishabhg71