Update WebLink to allow missing title and description #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Assistant's note and list system has been moved to Google Keep: https://support.google.com/keep/?p=migrated_from_assistant These items are annotated with a webLink that looks like this: { "webLink": { "kind": "notes#webLink", "url": "https://support.google.com/keep/?p=migrated_from_assistant", "provenanceUrl": "https://support.google.com/keep/?p=migrated_from_assistant", "hasThumbnailUrl": true } } Previously, it was assumed that "name" and "description" are guaranteed to be supplied in a webLink annotation. However, this is no longer the case. This commit updates the WebLink class accordingly, and adds a test case.
|
Thanks! Uploaded |
|
Thanks for the rapid merge and all the work you have put into this awesome
project!
…On Tue, Dec 12, 2023, 14:31 Kai ***@***.***> wrote:
Thanks! Uploaded 0.15.1.
—
Reply to this email directly, view it on GitHub
<#153 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD5RFYFSQ2ATX6NVBV6KADYI7225AVCNFSM6AAAAABAQAPA3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRGM4DCOJQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Assistant's note and list system has been moved to Google Keep:
https://support.google.com/keep/?p=migrated_from_assistant
These items are annotated with a webLink that looks like this:
Previously, it was assumed that "name" and "description" are guaranteed to be supplied in a webLink annotation. However, this is no longer the case. This commit updates the WebLink class accordingly, and adds a test case.
Fixes #152.