Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebLink to allow missing title and description #153

Merged
merged 1 commit into from
Dec 12, 2023

Commits on Dec 11, 2023

  1. Update WebLink to allow missing title and description

    Google Assistant's note and list system has been moved to Google Keep:
      https://support.google.com/keep/?p=migrated_from_assistant
    
    These items are annotated with a webLink that looks like this:
      {
        "webLink": {
          "kind": "notes#webLink",
          "url": "https://support.google.com/keep/?p=migrated_from_assistant",
          "provenanceUrl": "https://support.google.com/keep/?p=migrated_from_assistant",
          "hasThumbnailUrl": true
        }
      }
    
    Previously, it was assumed that "name" and "description" are
    guaranteed to be supplied in a webLink annotation.  However,
    this is no longer the case.  This commit updates the WebLink
    class accordingly, and adds a test case.
    jkitching committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    2aa0eef View commit details
    Browse the repository at this point in the history