Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Using custom renderer #49

Closed
FelixKratz opened this issue Feb 24, 2023 · 5 comments
Closed

[Question] Using custom renderer #49

FelixKratz opened this issue Feb 24, 2023 · 5 comments

Comments

@FelixKratz
Copy link

From the documentation I take that Firefox is the only supported renderer because of Selenium:

Firefox (Other browsers are not supported due to their limitation with Selenium)

My question is, what Selenium features would a renderer need to support to be usable with Jupynium?
Basically, I don't want to use Firefox to display the notebook and would be completely fine with creating
a custom solution via WebKit (like this one: https://github.com/FelixKratz/JupyterApp-mac).

@kiyoon
Copy link
Owner

kiyoon commented Feb 24, 2023

I tried with Chrome and Safari.

In Chrome, every time you type and the text gets updated it will focus on Chrome, which makes it unusable.

In Safari, they don't allow you to interact with the browser manually during Selenium automation. It makes it less usable.

@FelixKratz
Copy link
Author

Ok thanks, I will see if I can make it work.

@kiyoon
Copy link
Owner

kiyoon commented Feb 24, 2023

How does the web kit work? Does your web kit support Selenium?

You can modify src/jupynium/cmds/jupynium.py and there is a commented arg --browser. You can try and see if something works for you, and let me know if you found something.

@FelixKratz
Copy link
Author

Basically WebKit is a way to create a "browser-like" application that has much more access to the web content than a WebDriver. So I think it would be possible to "imitate" the necessary api in an app with a WebKit view, such that it properly conforms to all the Selenium api features you are targeting.

https://developer.apple.com/documentation/webkit

@kiyoon
Copy link
Owner

kiyoon commented Feb 24, 2023

Sounds promising. It seems like you may be able to make webkit version work, but we'll need to migrate all Selenium codes to webkit version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants