Changed markup to plain html, added linting to npm scripts; added editorconfig file #37
Conversation
this way the orders are downloaded only once at the start of the application instead of every time when the user navigates to `/`
This reverts commit 9ee5fb8.
updated linter rules as well
| @@ -23,6 +24,20 @@ | |||
| "babel-preset-es2015": "^6.6.0", | |||
| "babel-preset-react": "^6.5.0", | |||
| "babel-preset-stage-0": "^6.5.0", | |||
| "bootstrap": "^3.3.7", | |||
There was a problem hiding this comment.
Seems like dependencies and devDependencies are mixed up.
Everything that would be needed to build the app on production should listed as "dependencies" node. Things that are not for production like mocha should be listed as "devDependencies".
webpack/webpack#520
There was a problem hiding this comment.
shouldn't mocha also be in the dependencies to allow for
export NODE_ENV=production && npm i && npm test to be able to run tests using mocha under production environment? Otherwise you would have to remember (and the CI system) to set NODE_ENV to development before npm i
There was a problem hiding this comment.
fair point! I'm not sure if that is a common practice, to be honest
on production environment I'd go for running integration/smoke tests that treat the application as a black box
but if they treat it as a black box and use public api, it doesn't matter where they're run, they just need access to a running app
also, we don't have any tests here which is a whole other story
| filename: './src/public/[name].js' | ||
| path: path.resolve(__dirname, './src/public/'), | ||
| filename: '[name].js', | ||
| publichPath: '/public/' |
There was a problem hiding this comment.
publich -> public and then: why did it work? or it didn't?
There was a problem hiding this comment.
it looked ok oO, maybe only because we're not using glyphicons or something
… package.json; fixed webpack config
configured bootstrap with webpack (didn't google if there's a new, better way, probably should check)