Support P-521 curve #521
Support P-521 curve #521
Conversation
add missing base64x-1.1.js
|
Great work! Did you test the new (and modified) algorithm against some test vectors (e.g. http://point-at-infinity.org/ecc/nisttv)? |
|
No I didn't. I just used the existing tests. |
I don't know, what the acceptance criterias are here, but "Better safe than sorry ..."
The test vectors are for the underlying mathematical primitives: "For a given curve and a given base point P the point Q = kP was calcaluted for BTW: I suppose, that key generation for P521 is suffering from "getBigRandom() is incorrect #221". A test could verify that. |
- make ECDSA public key generation an own method so we can test it - test against the testvectors
|
I added the tests for these vectors, but they only test if the public key is created correctly. I think more important would be test vectors for signing and verification! @fpedrei Do you also know test-vectors for that? |
|
This project has a number of test vectors: https://github.com/google/wycheproof |
|
That are a lot of test vectors. They should probably be added in an own PR. If @kjur wants them? |
Hi @cplussharp , thank you kindly. I think I'll merge your PR this weekend. Of course, your test codes are very helpful for me. If possible, I'm happy to have P-521 test code with a separate file such as "qunit-do-crypto-ec-p521.html". |
|
Hi @cplussharp , thank you indeed for your effort. I've released 10.5.0 with your PR today. |
|
@cplussharp: If you're still looking for test vectors (signing and verification), there are some at the bottom of this page: https://csrc.nist.gov/Projects/cryptographic-algorithm-validation-program/digital-signatures |
implementation for #519