Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to manual deployment of page #16

Closed
wants to merge 1 commit into from
Closed

Conversation

kkmann
Copy link
Owner

@kkmann kkmann commented Jan 18, 2023

removed gh action to build & publish to gh-pages; manually deply to folder '_site'. Due to issues with quarto gh action #15

@kkmann kkmann marked this pull request as ready for review January 18, 2023 11:51
@kkmann kkmann added this to the Finish slides milestone Jan 18, 2023
@kkmann kkmann self-assigned this Jan 18, 2023
@danielinteractive
Copy link
Collaborator

Oh that is a pity! Are you sure we need to do that?

@kkmann
Copy link
Owner Author

kkmann commented Jan 18, 2023

It is, couldn't figure out what the issue is. And I think it is more important that we have the polished slides online that that the automatic buidl system works for now. Toothing issues. I even fixed the Quarto version to my local one, same problem :( Happy to switch back but don't want to spend time on it now.

@danielinteractive
Copy link
Collaborator

@cicdguy any ideas maybe on the quarto build issues mentioned by @kkmann? Just in case...

@cicdguy
Copy link

cicdguy commented Jan 18, 2023

I've also had issues with RStudio's Quarto action which is why I resorted to using a container-based workflow. This is what worked for when we used it for our R/Pharma workshop: https://github.com/pharmaverse/cicdworkshop.rinpharma2022/blob/9ec819ff80a3f966bcbf945d928f5fbaa1901f89/.github/workflows/presentations.yml

@kkmann
Copy link
Owner Author

kkmann commented Jan 19, 2023

Great idea, thanks! Will give it a shot.

@kkmann
Copy link
Owner Author

kkmann commented Jan 19, 2023

same issue, oO using a custom rverse derived container - I must be missing something...

@kkmann kkmann closed this Jan 19, 2023
@cicdguy
Copy link

cicdguy commented Jan 19, 2023

same issue, oO using a custom rverse derived container - I must be missing something...

Looks like a successful run to me: https://github.com/kkmann/workshop-r-swe/actions/runs/3960498316

@kkmann
Copy link
Owner Author

kkmann commented Jan 20, 2023

it does runs all right, but the artifact (website) is not consistent with what we get locally. Somehow ignores a few quarto options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants