-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DOMPurify from v2.0.8 to v2.0.11 #3
Conversation
Thank you @NicholasEllul for your contribution! |
@NicholasEllul I'm thinking about what kind of version increase to choose for this update (minor or patch). |
I think I will create a minor release this time because I've also added a simple smoke test for this repo and integrated with TravisCI #5 |
Released 0.3.0 |
I agree with you, it makes more sense for feature changes to result in a minor version bump instead of a patch in the version. Another idea I thought of: To make it easy for people to know which DOMPurify version they are using, we could copy DOMPurify's versioning. In other words, when DOMPurify releases version 3.0.1 we update isomorphic-dompurify to 3.0.1 as well. |
I like the idea of version mirroring with DOMPurify, and it makes a lot of sense, but what to do if we need to fix a bug in out project? |
Hmm good point. I opened cure53/DOMPurify#446 in DOMPurify. An idea for If they do start using correct semantic versioning: |
Created a separate issue to extract this topic from the closed PR. |
The full changelog can be found here --> https://github.com/cure53/DOMPurify/releases, but here is a screenshot for reference:
I also bump the DOMPurify types dependency to 2.0.2 since it includes the new interface for the
ADD_DATA_URI_TAGS
config that was added.