Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Feature/more tests #66

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

[WIP] Feature/more tests #66

wants to merge 33 commits into from

Conversation

kkondo1981
Copy link
Owner

See #65 .

@kkondo1981 kkondo1981 added the WIP Work In Progress label Jun 12, 2021
@kkondo1981
Copy link
Owner Author

  • Added vehicle insurance dataset with Gamma(link=log) AGLM
  • Fixed residuals() to handle general case. Note that old implementation other than deviance residuals seems easy to integrated into the new implementation, but remain it for a while because I need some regression test before changing it.

@kkondo1981
Copy link
Owner Author

  • Added a demo for French mortor TPL dataset with Poisson(link=log) AGLM.
  • Simplified residuals() as written in the previous comment, because I checked new implementation doesn't change results with Poisson case.

@kkondo1981
Copy link
Owner Author

  • Added a demo for MultinomialExample in glmnet with family="multinomial".
  • Modified plot.AccurateGLM() and coef.AccurateGLM() so that they can be used with multinomial regression. Note that residual.AccurateGLM() is not modified and couldn't handle with multinomial cases properly.
  • Added "demo/README.md" to show results of demos.

@kkondo1981
Copy link
Owner Author

  • Added a demo for the banknotes dataset with family="binomial".
  • Update all other demos and demo/README.md to compare AGLM with simple GLM (with cross-validation for alpha and lambda).
  • Modified aglm() and cv.aglm() to cope with binomial and multinomial regressions. Also modified residuals.AccurateGLM() to cope with binomial regressions (actually there was a bug and I fixed it) , but not finished for multinomial regressions.

@kkondo1981
Refactored before implementing the multinomial case.
669e275
@kkondo1981
Removed looops for class.
2236399
@kkondo1981
- Modified to draw multiple lines corresponding to all classes in one…
04e3cd5 
… plot in multinomial cases.

- Added `use_legend` and `margin` for `plot.AccurateGLM()` for adjusting (mainly) improving plotting for multinomial cases.
@kkondo1981
Modified to:
eba08ea 
- apply margins for barplot case too,
- use legends in multinomial cases for barplot,
- add the `color` parameter which works in all the cases of `lines`, `barplot`, `boxplot`.
@kkondo1981
Modified to apply margins for boxplot.
249c5d4
@kkondo1981
Added resid_col, smooth_col, and rug_col to `plot.AccurateGLM()…
d45a31c 
…` for changing colors of graphic components.
@kkondo1981
Forbidded to use residuals in multinomial cases.
b1785e2
@kkondo1981
Copy link
Owner Author

kkondo1981 commented Jul 11, 2021 •
edited
Loading

Modified plot.AccurateGLM(), mainly to adjust visuals in the case of multinomial regression.
Now plot.AccurateGLM():

  • draws components curves (or bars) of multiple classes in one plot instead of multiple plots,
  • has the parameter to use legends to distinguish components curves (or bars) of multiple classes (use_legend),
  • and has the parameters to adjusting colors of graphic components (col, resid_col, smooth_col, rug_col).

Furthermore, I disallowed to use resid=TRUE in multinomial cases, because plotting those may result slightly too complicated graphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kkondo1981