Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis connection kept open after application shutdown #1192

Closed
Davide-Gheri opened this issue Mar 23, 2023 · 0 comments · Fixed by #1214
Closed

Redis connection kept open after application shutdown #1192

Davide-Gheri opened this issue Mar 23, 2023 · 0 comments · Fixed by #1214

Comments

@Davide-Gheri
Copy link
Contributor

This issue was already fixed in the past by @mickaelmesdocteurs on #644 but now the flag used to check if it is required to close the connection is never set. The change happened in this PR #1038

Can we revert that change and restore the proper connection teardown?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added back disconnectRequired flag assignment Davide-Gheri/nestjs-throttler-storage-redis
1 participant
@Davide-Gheri