Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added back disconnectRequired flag assignment #1214

Merged
merged 1 commit into from
May 21, 2023

Conversation

Davide-Gheri
Copy link
Contributor

Adds back Redis connection close logic added in #644 but removed in #1038

Closes #1192

@alko89
Copy link

alko89 commented Apr 19, 2023

Is the disconnectRequired flag even necessary? Should work fine with simply calling disconnect?

onModuleDestroy() {
      this.redis?.disconnect(false);
}

@Davide-Gheri
Copy link
Contributor Author

The idea behind the flag was that if you provide a Redis instance yourself, this library should not be responsible of closing its connection.

@kkoomen kkoomen merged commit ec7edf0 into kkoomen:master May 21, 2023
@kkoomen
Copy link
Owner

kkoomen commented May 21, 2023

Release in v0.3.3 on NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis connection kept open after application shutdown
3 participants