Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disconnect redis to avoid open handles #644

Merged
merged 1 commit into from Nov 10, 2021
Merged

fix: disconnect redis to avoid open handles #644

merged 1 commit into from Nov 10, 2021

Conversation

mickaelmesdocteurs
Copy link
Contributor

@mickaelmesdocteurs mickaelmesdocteurs commented Nov 5, 2021 •
edited

Client application doing e2e tests with nestjs-throttler-storage-redis can leads to open handles error when using a configuration instead of ioredis instance.
Example: storage: new ThrottlerStorageRedisService(redisConfig)

at node_modules/ioredis/built/redis/index.js:268:48
      at Redis.Object.<anonymous>.Redis.connect (node_modules/ioredis/built/redis/index.js:258:21)
      at new Redis (node_modules/ioredis/built/redis/index.js:167:14)
      at new ThrottlerStorageRedisService (node_modules/nestjs-throttler-storage-redis/src/throttler-storage-redis.service.ts:21:20)

@kkoomen
Copy link
Owner

kkoomen commented Nov 10, 2021

LGTM :)

@kkoomen kkoomen merged commit c3a48d6 into kkoomen:master Nov 10, 2021
@kkoomen
Copy link
Owner

kkoomen commented Nov 10, 2021

This has been merged v0.1.16 git | NPM

@Davide-Gheri Davide-Gheri mentioned this pull request Mar 23, 2023
Closed
@Davide-Gheri Davide-Gheri mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mickaelmesdocteurs @kkoomen