Refactor docker deployment and user setup (#863) #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Errors in Photoview image photoview/photoview#862, address AppArmor not letting me run the container photoview/photoview#826 and maybe some other tickets: reimplemented the docker-compose user setup to enhance product setup experience and cover much more cases.
make unique DB container name and use it in communication from Photoview
Removed unnecessary healthcheck for photoview from docker-compose.example.yml, as it is defined in the Dockerfile; optimized Dockerfile combining all RUN directives of PROD stage into 1, which will produce single layer and save some space; added Dockerfile-dev, docker-compose-dev.yml, and new "dev" and "dev-down" directives into Makefile, which allows to setup development env in Docker. Instructions of how to use it are in comments at the beginning of Dockerfile-dev and docker-compose-dev.yml files
Set RWX permissions to the application's working folder for any user, so that the image could be later run with non-root permissions and the app still be able to do needed operations in the FS
Enhanced the "Getting started" section in the readme; added the
help
target and enhanced comments in the Makefile; commented out thedocker system prune -f
with the comment about the command and why it is there; added optional and commented by default7zz
commands to thebackup
section of the MakefileUse
slim
base image for final photoview imageImplement SQLite support according to the PR chore(docker-compose): add sqlite variable and volumes example photoview/photoview#851
Removed deprecated
version
line from compose files; optimized dockerfile to build with less layers and run as non-root; mapped only Photoview related services to Watchtower by default instead of updating all running images on a host; added template for Postgres to the .env; reverted compose executable definition, so the new compose is called when present; added a tip aboutlnav
to helpfix a typo in the username; add support of PostgreSQL; split and optimize backup target in Makefile
Fixed some typos and styling in Readme, excluded dev-environment setup from the PR; added a list of tips on how to secure Photoview in the Advanced setup section of Readme
Implemented many security improvements, suggested by @Omar007, switched to the dedicated Darktable's repo to install the latest released version, as asked in Darktable is out of date on edge docker image photoview/photoview#935; switched Watchtower to labels instead of profiles
forgot the compose file
move face models back to /app folder; comment out and document unnecessary vars in compose; fix a typo in a few vars
Exclude Makefile in the root folder from git; documented multiple mounts case better; fixed incorrect SQLite DB path
Fixed several bugs after complete testing cycle with all 3 DBs
removed hardcoded port in Dockerfile
Pin the major version for the
photoview
image for stabilityRevert back to the port 80 inside the container on product owner's request
Provide a minimal compose file and update the readme accordingly
Handle incorrect media file and folder permissions; set correct permissions for storage folder; fix healthcheck command for postgres