Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a new release? #760

Open
petterreinholdtsen opened this issue Apr 10, 2023 · 8 comments
Open

Time for a new release? #760

petterreinholdtsen opened this issue Apr 10, 2023 · 8 comments

Comments

@petterreinholdtsen
Copy link

I notice the last release of ffmpeg-python was released in 2019. Perhaps it is time to wrap up a new release? Is this library still being maintained? The number of open pull requests and issues make me wonder. If it is, I would love to see this library distributed from the Debian project to become available in all the Linux distributions derived from Debian, like Ubuntu and Kali. Is this something you would be interested in making happen?

@petterreinholdtsen
Copy link
Author

The OpenHub project indicators on https://openhub.net/p/ffmpeg-python have some worrying observations.

petterreinholdtsen added a commit to petterreinholdtsen/whisper that referenced this issue Apr 16, 2023
The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >
@petterreinholdtsen
Copy link
Author

The request for packaging of ffmpeg-python in Debian is https://bugs.debian.org/1034286 . Because of the amount of response here as well the number of open issues and pull requests I decided to not push forward to get ffmpeg-python in Debian and instead adjust OpenAI Whisper to work without it.

jongwook added a commit to openai/whisper that referenced this issue May 4, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly.

The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >

* Rewrote to use subprocess.run() instead of subprocess.Popen().

* formatting changes

* formatting update

* isort fix

* Error checking

* isort 🤦🏻

* flake8 fix

* minor spelling changes

---------

Co-authored-by: Jong Wook Kim <jongwook@openai.com>
zackees pushed a commit to zackees/whisper that referenced this issue May 5, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly.

The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >

* Rewrote to use subprocess.run() instead of subprocess.Popen().

* formatting changes

* formatting update

* isort fix

* Error checking

* isort 🤦🏻

* flake8 fix

* minor spelling changes

---------

Co-authored-by: Jong Wook Kim <jongwook@openai.com>
ilanit1997 pushed a commit to ilanit1997/whisper that referenced this issue May 16, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly.

The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >

* Rewrote to use subprocess.run() instead of subprocess.Popen().

* formatting changes

* formatting update

* isort fix

* Error checking

* isort 🤦🏻

* flake8 fix

* minor spelling changes

---------

Co-authored-by: Jong Wook Kim <jongwook@openai.com>
@jgarte
Copy link

jgarte commented Jul 22, 2023

@petterreinholdtsen Should we be using this library instead?

https://github.com/jonghwanhyeon/python-ffmpeg

Have you had time to review the library by jonghwanhyeon?

Guix contributor, Parnikkapore, recently submitted a patch to GNU Guix for this library but the latest release has some incompatibilities with our latest packaged CPython requiring patching imports:

https://issues.guix.gnu.org/64732#7

I wonder if we should just use a more up to date ffmpeg-python from else somewhere instead.

@parnikkapore
Copy link

parnikkapore commented Jul 22, 2023

(It's a me! 😀)

AFAICT this library is primarily a more friendly surface syntax for FFmpeg filtergraphs (read: a way to write filtergraphs more python-ically); neither python-ffmpeg nor imageio-ffmpeg fulfills this task AFAICT.

Whisper does not need to dynamically build up a filtergraph, so it can hard-code the arguments.

Unfortunately for me, r128gain does.

@parnikkapore
Copy link

For any future souls surfacing this in a search, ffmpegio has a filtergraph builder and is still maintained as of this writing. Not as perused as this one though.

@jgarte
Copy link

jgarte commented Jul 22, 2023

@parnikkapore Hi!

Reading through the docs for python-ffmpeg, I can see how python-ffmpeg doesn't have the API niceties that ffmpeg-python does.

@parnikkapore I think we should choose a later commit of ffmpeg-python instead of patching the old release. Could you send a v4 to Guix for that and add a comment describing why near the let statement specifying the commit hash?

Let's continue the thread over at #64732 on the mumi bug tracker.

@jgarte
Copy link

jgarte commented Jul 22, 2023

For any future souls surfacing this in a search, ffmpegio has a filtergraph builder and is still maintained as of this writing. Not as perused as this one though.

Nice __idea__.

abyesilyurt pushed a commit to abyesilyurt/whisper that referenced this issue Nov 13, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly.

The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >

* Rewrote to use subprocess.run() instead of subprocess.Popen().

* formatting changes

* formatting update

* isort fix

* Error checking

* isort 🤦🏻

* flake8 fix

* minor spelling changes

---------

Co-authored-by: Jong Wook Kim <jongwook@openai.com>
stainless-app bot pushed a commit to 2lambda123/openai-whisper that referenced this issue Feb 3, 2024
* Drop ffmpeg-python dependency and call ffmpeg directly.

The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >

* Rewrote to use subprocess.run() instead of subprocess.Popen().

* formatting changes

* formatting update

* isort fix

* Error checking

* isort 🤦🏻

* flake8 fix

* minor spelling changes

---------

Co-authored-by: Jong Wook Kim <jongwook@openai.com>
@kyrlon
Copy link

kyrlon commented Apr 10, 2024

Is repository still being maintained?

smartluck1125 added a commit to smartluck1125/whisper that referenced this issue May 9, 2024
* Drop ffmpeg-python dependency and call ffmpeg directly.

The last ffmpeg-python module release was in 2019[1], upstream seem to be
unavailable[2] and the project development seem to have stagnated[3].  As
the features it provide is trivial to replace using the Python native
subprocess module, drop the dependency.

 [1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
 [2] <URL: kkroening/ffmpeg-python#760 >
 [3] <URL: https://openhub.net/p/ffmpeg-python >

* Rewrote to use subprocess.run() instead of subprocess.Popen().

* formatting changes

* formatting update

* isort fix

* Error checking

* isort 🤦🏻

* flake8 fix

* minor spelling changes

---------

Co-authored-by: Jong Wook Kim <jongwook@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants