Drop ffmpeg-python dependency and call ffmpeg directly. #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python >
|
[Glenn Langford]
Good idea, but should this use `run()` rather than `Popen()`?
I went with Popen because I need the pipe and knew how to use it. What
would be the advantage of using run()?
…--
Happy hacking
Petter Reinholdtsen
|
|
I added a commit to switch from Popen() to run(). Feel free to use the approach you like. |
x86Gr
approved these changes
Apr 19, 2023
|
We're running into some issues with ffmpeg-python when running on FIPS environment, it'd be good to have the ffmpeg-python removed. Any word on when this PR can be merged? |
|
[szelenka]
We're running into some issues with ffmpeg-python when running on FIPS
environment, it'd be good to have the ffmpeg-python removed. Any word
on when this PR can be merged?
I have not heard anything about it. I do not know the evaluation process
used by this project, so no idea who could make any reliable statement
about it.
I've included the patch in the Debian packages I am working on, to avoid
introducing and depending on what appear to be unmaintained software
into Debian.
…--
Happy hacking
Petter Reinholdtsen
|
|
@petterreinholdtsen do we have any method to contact the maintainers of openai/whisper to merge this PR? @glangford is this PR good to go now? |
|
[szelenka]
@petterreinholdtsen do we have any method to contact the maintainers
of openai/whisper to merge this PR?
Not besides nagging here, no.
…--
Happy hacking
Petter Reinholdtsen
|
|
Thanks! Other than tidying up the dependencies, did you have any missing features or security concerns from ffmpeg-python? |
|
[Jong Wook Kim]
Thanks! Other than tidying up the dependencies, did you have any
missing features or security concerns from ffmpeg-python?
My concern were mostly from a maintenance point of view. There seem to
be no active maintainer nor any active maintenance of the library, so
depending on it seem like a fairly high risk for no gain. I wanted to
get Whisper into Debian and did not feel like introducing an upstream
orphaned ffmpeg-python as a package in Debian, were one is expected to
keep it working well for 3-4 years.
How do the Whisper developers evaluate ffmpeg-python sustainability?
…--
Happy hacking
Petter Reinholdtsen
|
|
@jongwook It'd be an easy fix to ffmpeg-python, but as @petterreinholdtsen mentioned, this is an abandoned project .. so nobody can merge the PRs there. |
zackees
pushed a commit
to zackees/whisper
that referenced
this pull request
May 5, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <jongwook@openai.com>
ilanit1997
pushed a commit
to ilanit1997/whisper
that referenced
this pull request
May 16, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <jongwook@openai.com>
abyesilyurt
pushed a commit
to abyesilyurt/whisper
that referenced
this pull request
Nov 13, 2023
* Drop ffmpeg-python dependency and call ffmpeg directly. The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency. [1] <URL: https://github.com/kkroening/ffmpeg-python/tags > [2] <URL: kkroening/ffmpeg-python#760 > [3] <URL: https://openhub.net/p/ffmpeg-python > * Rewrote to use subprocess.run() instead of subprocess.Popen(). * formatting changes * formatting update * isort fix * Error checking * isort 🤦🏻 * flake8 fix * minor spelling changes --------- Co-authored-by: Jong Wook Kim <jongwook@openai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last ffmpeg-python module release was in 2019[1], upstream seem to be unavailable[2] and the project development seem to have stagnated[3]. As the features it provide is trivial to replace using the Python native subprocess module, drop the dependency.
[1] <URL: https://github.com/kkroening/ffmpeg-python/tags >
[2] <URL: kkroening/ffmpeg-python#760 >
[3] <URL: https://openhub.net/p/ffmpeg-python >