-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #195. Redirect stdout/err to /dev/null #417
Conversation
Any news on this one? Straightforward change |
Have you already tested the code? |
@ArchieMeng could you check with the latest version? I changed it slightly to cover all cases. I tested in my use case, which is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone else please confirm that this works as intended?
Patched and running fine in v0.2.0. Here's how def run(self):
"""
Run channel encoder
"""
self.process = (
self.output.run_async(
quiet=self.quiet
)
)
self.print("Running")
return_code = self.process.wait()
if return_code:
self.print(f"Exited with code {return_code}") |
Just for the record, the secret here is to redirect |
That's a weird bug 🤔 |
Yes. It works. Thank you. |
Fixes #195
Redirect stdout/stderr to DEVNULL when quiet is requested, otherwise, the buffer will be filled until a MemoryError on long encodings.