Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vyper contracts #1109

Merged
merged 12 commits into from
Apr 19, 2024
Merged

add vyper contracts #1109

merged 12 commits into from
Apr 19, 2024

Conversation

swetshaw
Copy link
Contributor

@swetshaw swetshaw commented Apr 17, 2024

Time spent on this PR: 1 hour

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Added Vyper contracts

What is the current behavior?

Resolves #1108


This change is Reviewable

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you miss a poetry add vyper somewhere, and also don't all contracts we don't use, only the one we need (3074InvokePoc I guess) and fix case in naming

possibly also add a readme or command in the makefile to actually compile these files

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ClementWalter
Copy link
Member

Tested against katana with this script

import os
os.environ["STARKNET_NETWORK"] = "katana"
from kakarot_scripts.utils.kakarot import *

eip3074 = await deploy("EIP3074", "AuthorizedTransfer")
await eip3074.counter()
INFO:kakarot_scripts.utils.kakarot:⏳ Deploying AuthorizedTransfer
INFO:kakarot_scripts.utils.kakarot:ℹ️  Contract at address 0x44712b3de69e23f62641a220dc282cab01f6073a0c7db38e9b658253005d161 already exists
INFO:kakarot_scripts.utils.kakarot:✅ AuthorizedTransfer deployed at address 0x5FC8d32690cc91D4c39d9d3abcBD16989F875707
0

ClementWalter
ClementWalter previously approved these changes Apr 18, 2024
@ClementWalter ClementWalter merged commit f1b037b into kkrt-labs:main Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add vyper contracts
3 participants