Add info about left calculation method #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment to use the left calculation method if the house has solar panels installed as the default trapezoidal calculates wrong values if the consumpiton is 0 for an extended period of time
|
Please refer to |
|
I would prefer to omit the comment piece and include it in the FAQ |
klaasnicolaas
added
the
enhancement
|
Sure, will do that |
|
Closing the PR wouldn't really have been necessary, you can just make and push a commit 😅 |
|
Done, sorry I am new to this |
klaasnicolaas
changed the title
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
klaasnicolaas
added
no-stale
|
Could you perhaps convert this FAQ to the new format on the documentation website, these will no longer go into the readme file. |
|
Sure, I will close this pull request as the branch was out of sync and created a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a comment to use the left calculation method if the house has solar panels installed as the default trapezoidal calculates wrong values if the consumpiton is 0 for an extended period of time