General refactor/restructure of the project #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaasnicolaas
added
the
refactor
MarijnS95
reviewed
Mar 29, 2023
MarijnS95
reviewed
Mar 29, 2023
|
The list of issues to smash 😄 |
This was referenced Apr 1, 2023
* Fix remainder of ruff lints
* Revert TCP error messages
General communication messages for read and write are caught and raised
during `wait_closed()`.
* Attempt to fix missing coverage on 108->exit
* Ignore `PGH003` for type skip
* use `type: ignore[unreachable]` instead
* Fix coverage by moving `self._close_session=False` out of `if`
Somehow `codecov` is not able to deduce that `_close_session` is `False`
if the `if` was not entered.
* Improve and reuse `close()` function
* Ignore type-less subclass with `misc` instead of `unreachable` ignore
The type is still reachable, `mypy` simply doesn't have type info hence
considers it as the `Any` type which shouldn't be subclassed:
tests/test_tcp_models.py:206: error: Unused "type: ignore" comment
tests/test_tcp_models.py:206: error: Class cannot subclass "TestCase" (has type "Any") [misc]
tests/test_tcp_models.py:206: note: Error code "misc" not covered by "type: ignore" comment
* Make content_type check less strict again
klaasnicolaas
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 327 343 +16
Branches 55 54 -1
=========================================
+ Hits 327 343 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
klaasnicolaas
commented
Apr 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General restructure/refactor of the project.