tests: Replace deprecated asynctest with manual TCP socket in Thread
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MarijnS95
commented
Apr 7, 2023
MarijnS95
commented
Apr 7, 2023
|
Time to rebase 😉 |
…read` `asynctest` is unmaintained and deprecated yet there appears to be no clean replacement to mock the `async` methods of an `asyncio` client socket, as previously passed to `asyncio.open_connection()`. Instead of inventing a complicated `asyncio` solution around this, create and bind a `socket` (so that we know the randomly chosen open port upfront) and accept a single client within a `Thread`. This temporary `Thread` closes the connection and can later be `join()`ed when the test is over to make sure it has finalized and exited.
The client only connects to `localhost` after all, no need to bind all interfaces.
MarijnS95
force-pushed
the
replace-asynctest
branch
from
400a416
to
b8ffb35
Compare
klaasnicolaas
added
the
refactor
…ection reset by peer")`
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 343 341 -2
Branches 54 54
=========================================
- Hits 343 341 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #361 and #365
For #305
asynctestis unmaintained and deprecated yet there appears to be no clean replacement to mock theasyncmethods of anasyncioclient socket, as previously passed toasyncio.open_connection(). Instead of inventing a complicatedasynciosolution around this, create and bind asocket(so that we know the randomly chosen open port upfront) and accept a single client within aThread. This temporaryThreadcloses the connection and can later bejoin()ed when the test is over to make sure it has finalized and exited.