Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update dependency aiohttp to v3.9.0 [SECURITY] #540

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 28, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
aiohttp 3.8.6 -> 3.9.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-49082

Summary

Improper validation makes it possible for an attacker to modify the HTTP request (e.g. insert a new header) or even create a new HTTP request if the attacker controls the HTTP method.

Details

The vulnerability occurs only if the attacker can control the HTTP method (GET, POST etc.) of the request.

Previous releases performed no validation on the provided value. If an attacker controls the HTTP method it will be used as is and can lead to HTTP request smuggling.

PoC

A minimal example can be found here:
https://gist.github.com/jnovikov/7f411ae9fe6a9a7804cf162a3bdbb44b

Impact

If the attacker can control the HTTP version of the request it will be able to modify the request (request smuggling).

Workaround

If unable to upgrade and using user-provided values for the request method, perform manual validation of the user value (e.g. by restricting it to a few known values like GET, POST etc.).

CVE-2023-49081

Summary

Improper validation make it possible for an attacker to modify the HTTP request (e.g. to insert a new header) or even create a new HTTP request if the attacker controls the HTTP version.

Details

The vulnerability only occurs if the attacker can control the HTTP version of the request (including its type).
For example if an unvalidated JSON value is used as a version and the attacker is then able to pass an array as the version parameter.
Furthermore, the vulnerability only occurs when the Connection header is passed to the headers parameter.

At this point, the library will use the parsed value to create the request. If a list is passed, then it bypasses validation and it is possible to perform CRLF injection.

PoC

The POC below shows an example of providing an unvalidated array as a version:
https://gist.github.com/jnovikov/184afb593d9c2114d77f508e0ccd508e

Impact

CRLF injection leading to Request Smuggling.

Workaround

If these specific conditions are met and you are unable to upgrade, then validate the user input to the version parameter to ensure it is a str.


Release Notes

aio-libs/aiohttp (aiohttp)

v3.9.0

Compare Source

==================

Features

  • Introduced AppKey for static typing support of Application storage.
    See https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config

    #&#8203;5864 <https://github.com/aio-libs/aiohttp/issues/5864>_

  • Added a graceful shutdown period which allows pending tasks to complete before the application's cleanup is called.
    The period can be adjusted with the shutdown_timeout parameter. -- by :user:Dreamsorcerer.
    See https://docs.aiohttp.org/en/latest/web_advanced.html#graceful-shutdown

    #&#8203;7188 <https://github.com/aio-libs/aiohttp/issues/7188>_

  • Added handler_cancellation <https://docs.aiohttp.org/en/stable/web_advanced.html#web-handler-cancellation>_ parameter to cancel web handler on client disconnection. -- by :user:mosquito
    This (optionally) reintroduces a feature removed in a previous release.
    Recommended for those looking for an extra level of protection against denial-of-service attacks.

    #&#8203;7056 <https://github.com/aio-libs/aiohttp/issues/7056>_

  • Added support for setting response header parameters max_line_size and max_field_size.

    #&#8203;2304 <https://github.com/aio-libs/aiohttp/issues/2304>_

  • Added auto_decompress parameter to ClientSession.request to override ClientSession._auto_decompress. -- by :user:Daste745

    #&#8203;3751 <https://github.com/aio-libs/aiohttp/issues/3751>_

  • Changed raise_for_status to allow a coroutine.

    #&#8203;3892 <https://github.com/aio-libs/aiohttp/issues/3892>_

  • Added client brotli compression support (optional with runtime check).

    #&#8203;5219 <https://github.com/aio-libs/aiohttp/issues/5219>_

  • Added client_max_size to BaseRequest.clone() to allow overriding the request body size. -- :user:anesabml.

    #&#8203;5704 <https://github.com/aio-libs/aiohttp/issues/5704>_

  • Added a middleware type alias aiohttp.typedefs.Middleware.

    #&#8203;5898 <https://github.com/aio-libs/aiohttp/issues/5898>_

  • Exported HTTPMove which can be used to catch any redirection request
    that has a location -- :user:dreamsorcerer.

    #&#8203;6594 <https://github.com/aio-libs/aiohttp/issues/6594>_

  • Changed the path parameter in web.run_app() to accept a pathlib.Path object.

    #&#8203;6839 <https://github.com/aio-libs/aiohttp/issues/6839>_

  • Performance: Skipped filtering CookieJar when the jar is empty or all cookies have expired.

    #&#8203;7819 <https://github.com/aio-libs/aiohttp/issues/7819>_

  • Performance: Only check origin if insecure scheme and there are origins to treat as secure, in CookieJar.filter_cookies().

    #&#8203;7821 <https://github.com/aio-libs/aiohttp/issues/7821>_

  • Performance: Used timestamp instead of datetime to achieve faster cookie expiration in CookieJar.

    #&#8203;7824 <https://github.com/aio-libs/aiohttp/issues/7824>_

  • Added support for passing a custom server name parameter to HTTPS connection.

    #&#8203;7114 <https://github.com/aio-libs/aiohttp/issues/7114>_

  • Added support for using Basic Auth credentials from :file:.netrc file when making HTTP requests with the
    :py:class:~aiohttp.ClientSession trust_env argument is set to True. -- by :user:yuvipanda.

    #&#8203;7131 <https://github.com/aio-libs/aiohttp/issues/7131>_

  • Turned access log into no-op when the logger is disabled.

    #&#8203;7240 <https://github.com/aio-libs/aiohttp/issues/7240>_

  • Added typing information to RawResponseMessage. -- by :user:Gobot1234

    #&#8203;7365 <https://github.com/aio-libs/aiohttp/issues/7365>_

  • Removed async-timeout for Python 3.11+ (replaced with asyncio.timeout() on newer releases).

    #&#8203;7502 <https://github.com/aio-libs/aiohttp/issues/7502>_

  • Added support for brotlicffi as an alternative to brotli (fixing Brotli support on PyPy).

    #&#8203;7611 <https://github.com/aio-libs/aiohttp/issues/7611>_

  • Added WebSocketResponse.get_extra_info() to access a protocol transport's extra info.

    #&#8203;7078 <https://github.com/aio-libs/aiohttp/issues/7078>_

  • Allow link argument to be set to None/empty in HTTP 451 exception.

    #&#8203;7689 <https://github.com/aio-libs/aiohttp/issues/7689>_

Bugfixes

  • Implemented stripping the trailing dots from fully-qualified domain names in Host headers and TLS context when acting as an HTTP client.
    This allows the client to connect to URLs with FQDN host name like https://example.com./.
    -- by :user:martin-sucha.

    #&#8203;3636 <https://github.com/aio-libs/aiohttp/issues/3636>_

  • Fixed client timeout not working when incoming data is always available without waiting. -- by :user:Dreamsorcerer.

    #&#8203;5854 <https://github.com/aio-libs/aiohttp/issues/5854>_

  • Fixed readuntil to work with a delimiter of more than one character.

    #&#8203;6701 <https://github.com/aio-libs/aiohttp/issues/6701>_

  • Added __repr__ to EmptyStreamReader to avoid AttributeError.

    #&#8203;6916 <https://github.com/aio-libs/aiohttp/issues/6916>_

  • Fixed bug when using TCPConnector with ttl_dns_cache=0.

    #&#8203;7014 <https://github.com/aio-libs/aiohttp/issues/7014>_

  • Fixed response returned from expect handler being thrown away. -- by :user:Dreamsorcerer

    #&#8203;7025 <https://github.com/aio-libs/aiohttp/issues/7025>_

  • Avoided raising UnicodeDecodeError in multipart and in HTTP headers parsing.

    #&#8203;7044 <https://github.com/aio-libs/aiohttp/issues/7044>_

  • Changed sock_read timeout to start after writing has finished, avoiding read timeouts caused by an unfinished write. -- by :user:dtrifiro

    #&#8203;7149 <https://github.com/aio-libs/aiohttp/issues/7149>_

  • Fixed missing query in tracing method URLs when using yarl 1.9+.

    #&#8203;7259 <https://github.com/aio-libs/aiohttp/issues/7259>_

  • Changed max 32-bit timestamp to an aware datetime object, for consistency with the non-32-bit one, and to avoid a DeprecationWarning on Python 3.12.

    #&#8203;7302 <https://github.com/aio-libs/aiohttp/issues/7302>_

  • Fixed EmptyStreamReader.iter_chunks() never ending. -- by :user:mind1m

    #&#8203;7616 <https://github.com/aio-libs/aiohttp/issues/7616>_

  • Fixed a rare RuntimeError: await wasn't used with future exception. -- by :user:stalkerg

    #&#8203;7785 <https://github.com/aio-libs/aiohttp/issues/7785>_

  • Fixed issue with insufficient HTTP method and version validation.

    #&#8203;7700 <https://github.com/aio-libs/aiohttp/issues/7700>_

  • Added check to validate that absolute URIs have schemes.

    #&#8203;7712 <https://github.com/aio-libs/aiohttp/issues/7712>_

  • Fixed unhandled exception when Python HTTP parser encounters unpaired Unicode surrogates.

    #&#8203;7715 <https://github.com/aio-libs/aiohttp/issues/7715>_

  • Updated parser to disallow invalid characters in header field names and stop accepting LF as a request line separator.

    #&#8203;7719 <https://github.com/aio-libs/aiohttp/issues/7719>_

  • Fixed Python HTTP parser not treating 204/304/1xx as an empty body.

    #&#8203;7755 <https://github.com/aio-libs/aiohttp/issues/7755>_

  • Ensure empty body response for 1xx/204/304 per RFC 9112 sec 6.3.

    #&#8203;7756 <https://github.com/aio-libs/aiohttp/issues/7756>_

  • Fixed an issue when a client request is closed before completing a chunked payload. -- by :user:Dreamsorcerer

    #&#8203;7764 <https://github.com/aio-libs/aiohttp/issues/7764>_

  • Edge Case Handling for ResponseParser for missing reason value.

    #&#8203;7776 <https://github.com/aio-libs/aiohttp/issues/7776>_

  • Fixed ClientWebSocketResponse.close_code being erroneously set to None when there are concurrent async tasks receiving data and closing the connection.

    #&#8203;7306 <https://github.com/aio-libs/aiohttp/issues/7306>_

  • Added HTTP method validation.

    #&#8203;6533 <https://github.com/aio-libs/aiohttp/issues/6533>_

  • Fixed arbitrary sequence types being allowed to inject values via version parameter. -- by :user:Dreamsorcerer

    #&#8203;7835 <https://github.com/aio-libs/aiohttp/issues/7835>_

  • Performance: Fixed increase in latency with small messages from websocket compression changes.

    #&#8203;7797 <https://github.com/aio-libs/aiohttp/issues/7797>_

Improved Documentation

  • Fixed the ClientResponse.release's type in the doc. Changed from comethod to method.

    #&#8203;5836 <https://github.com/aio-libs/aiohttp/issues/5836>_

  • Added information on behavior of base_url parameter in ClientSession.

    #&#8203;6647 <https://github.com/aio-libs/aiohttp/issues/6647>_

  • Fixed ClientResponseError docs.

    #&#8203;6700 <https://github.com/aio-libs/aiohttp/issues/6700>_

  • Updated Redis code examples to follow the latest API.

    #&#8203;6907 <https://github.com/aio-libs/aiohttp/issues/6907>_

  • Added a note about possibly needing to update headers when using on_response_prepare. -- by :user:Dreamsorcerer

    #&#8203;7283 <https://github.com/aio-libs/aiohttp/issues/7283>_

  • Completed trust_env parameter description to honor wss_proxy, ws_proxy or no_proxy env.

    #&#8203;7325 <https://github.com/aio-libs/aiohttp/issues/7325>_

  • Expanded SSL documentation with more examples (e.g. how to use certifi). -- by :user:Dreamsorcerer

    #&#8203;7334 <https://github.com/aio-libs/aiohttp/issues/7334>_

  • Fix, update, and improve client exceptions documentation.

    #&#8203;7733 <https://github.com/aio-libs/aiohttp/issues/7733>_

Deprecations and Removals

  • Added shutdown_timeout parameter to BaseRunner, while
    deprecating shutdown_timeout parameter from BaseSite. -- by :user:Dreamsorcerer

    #&#8203;7718 <https://github.com/aio-libs/aiohttp/issues/7718>_

  • Dropped Python 3.6 support.

    #&#8203;6378 <https://github.com/aio-libs/aiohttp/issues/6378>_

  • Dropped Python 3.7 support. -- by :user:Dreamsorcerer

    #&#8203;7336 <https://github.com/aio-libs/aiohttp/issues/7336>_

  • Removed support for abandoned tokio event loop. -- by :user:Dreamsorcerer

    #&#8203;7281 <https://github.com/aio-libs/aiohttp/issues/7281>_

Misc

  • Made print argument in run_app() optional.

    #&#8203;3690 <https://github.com/aio-libs/aiohttp/issues/3690>_

  • Improved performance of ceil_timeout in some cases.

    #&#8203;6316 <https://github.com/aio-libs/aiohttp/issues/6316>_

  • Changed importing Gunicorn to happen on-demand, decreasing import time by ~53%. -- :user:Dreamsorcerer

    #&#8203;6591 <https://github.com/aio-libs/aiohttp/issues/6591>_

  • Improved import time by replacing http.server with http.HTTPStatus.

    #&#8203;6903 <https://github.com/aio-libs/aiohttp/issues/6903>_

  • Fixed annotation of ssl parameter to disallow True. -- by :user:Dreamsorcerer.

    #&#8203;7335 <https://github.com/aio-libs/aiohttp/issues/7335>_



Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Upgrade or downgrade of project dependencies. python labels Nov 28, 2023
@renovate renovate bot enabled auto-merge (rebase) November 28, 2023 04:21
@renovate renovate bot force-pushed the renovate/pypi-aiohttp-vulnerability branch 8 times, most recently from d3e0f82 to b6107f5 Compare December 11, 2023 04:10
@renovate renovate bot force-pushed the renovate/pypi-aiohttp-vulnerability branch 6 times, most recently from 372294c to 67fb3ee Compare December 15, 2023 12:21
@renovate renovate bot force-pushed the renovate/pypi-aiohttp-vulnerability branch 5 times, most recently from 6baf4a2 to 3f27f67 Compare December 25, 2023 03:51
@renovate renovate bot force-pushed the renovate/pypi-aiohttp-vulnerability branch from 3f27f67 to 4e88ccf Compare December 28, 2023 03:45
@renovate renovate bot force-pushed the renovate/pypi-aiohttp-vulnerability branch from 4e88ccf to dd9ac0d Compare December 30, 2023 01:08
@klaasnicolaas klaasnicolaas merged commit 35d263c into main Dec 30, 2023
17 of 23 checks passed
@renovate renovate bot deleted the renovate/pypi-aiohttp-vulnerability branch December 30, 2023 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant