Fixed a bug in RSVP stimuli and a rounding issue in stimulus duration #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the second frame and not hte first of an rsvp item. (This requires the call to localizeParms(s,true)). Fixes a bug/oddity with duration: Previously the offFrame was determined by rounding on+duration to the nearest frame. But the onFrame was determined by rounding on alone. In the current code, on is rounded first, and then duration is rounded separately, and the offFrame calculation is done by adding onFrame+durationFrame This has the advantage that a duration less than half a frame will always round to zero and this no longer depends on the on-time Example: on =1, duration =0.4 round(1) = 1, round(1 + 0.4) = 1 no stimulus shown, because onFrame =1, offFrame =1 But if on= 1.4 round(1.4)= 1, and round (1.4+0.4) = 2 one stimulus frame shown in frame 1
bartkrekelberg
commented
Mar 10, 2021
| else % Is on already or turning on. | ||
| % Checck that we have not reached full duration yet. | ||
| % No +1 here. | ||
| sOffFrame = sOnFrame + round(s.loc_duration*s.cic.screen.frameRate/1000); |
There was a problem hiding this comment.
This is the key change for the duration fix.
bartkrekelberg
commented
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in which localized parameters in an RSVP would update in the second frame and not hte first of an rsvp item. (This requires the call to localizeParms(s,true)).
Fixes a bug/oddity with duration:
Previously the offFrame was determined by rounding on+duration to the nearest frame. But the onFrame was determined by rounding on alone.
In the current code, on is rounded first, and then duration is rounded separately, and the offFrame calculation is done by adding onFrame+durationFrame
This has the advantage that a duration less than half a frame will always round to zero and this no longer depends on the on-time
Example: on =1, duration =0.4
round(1) = 1, round(1 + 0.4) = 1
no stimulus shown, because onFrame =1, offFrame =1
But if on= 1.4
round(1.4)= 1, and round (1.4+0.4) = 2
one stimulus frame shown in frame 1