Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in RSVP stimuli and a rounding issue in stimulus duration #158

Merged
merged 2 commits into from
Mar 25, 2021

Commits on Mar 10, 2021

  1. Fixes a bug in which localized parameters in an RSVP would update in …

    …the second frame and not hte first of an rsvp item. (This requires the call to localizeParms(s,true)).
    
    Fixes a bug/oddity with duration:
    
    Previously the offFrame was determined by rounding  on+duration to the nearest frame.  But the onFrame was determined by rounding on alone.
    In the current code, on is rounded first, and then duration is rounded separately, and the offFrame calculation is done by adding onFrame+durationFrame
    This has the advantage that a duration less than half a frame will always round to zero and this no longer depends on the on-time
    Example: on =1, duration =0.4
    round(1) = 1, round(1 + 0.4) = 1
    no stimulus shown, because onFrame =1, offFrame =1
    
    But if on= 1.4
    round(1.4)= 1, and round (1.4+0.4) = 2
    one stimulus frame shown in frame 1
    bartkrekelberg committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    bd792ea View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Configuration menu
    Copy the full SHA
    f688186 View commit details
    Browse the repository at this point in the history