Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: Add dictionaries with options (BREAKING) #268

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

klauspost
Copy link
Owner

RegisterDict was a bad design and unsafe/racy to use if a decoder was provided with a reader.

Instead add WithDecoderDicts that allows to specify the dictionaries with decoder options.

`RegisterDict` was a bad design and unsafe/racy to use if a decoder was provided with a reader.

Instead add `WithDecoderDicts` that allows to specify the dictionaries with decoder options.
@klauspost klauspost merged commit db51c49 into master Jun 11, 2020
@klauspost klauspost deleted the zstd-add-dicts-in-options branch June 11, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant