Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks at CPUID leaves it should not #117

Closed
DemiMarie opened this issue Aug 24, 2022 · 5 comments · Fixed by #118
Closed

Looks at CPUID leaves it should not #117

DemiMarie opened this issue Aug 24, 2022 · 5 comments · Fixed by #118

Comments

@DemiMarie
Copy link

A few months ago, @fosslinux reported that this code package looped forever under Xen. This has since been fixed, but it turns out that this code does not check if TOPOEXT is exposed before using it. Feel free to close if this has since been fixed.
@DemiMarie
Copy link
Author

I see that the loop was fixed in 2a5efe8 but this code should not even try to query the cache values unless TOPOEXT is enabled.

@klauspost
Copy link
Owner

@DemiMarie Do you happen to have any link to documentation for that?

@DemiMarie
Copy link
Author

@klauspost Not offhand, but it would be in the AMD programmer manuals.

klauspost added a commit that referenced this issue Aug 26, 2022
@klauspost
Skip AMD leaf 0x8000001d parsing if no TOPEXT
a946455 
Add flag for TopologyExtensions, use it when detecting.

Fixes #117
@klauspost klauspost mentioned this issue Aug 26, 2022
Merged
klauspost added a commit that referenced this issue Aug 26, 2022
@klauspost
Skip AMD leaf 0x8000001d parsing if no TOPEXT (#118)
976c648 
* Skip AMD leaf 0x8000001d parsing if no TOPEXT

Add flag for TopologyExtensions, use it when detecting.

Fixes #117

* Upgrade CI to Go 1.19
@klauspost
Copy link
Owner

Added & Released

@DemiMarie
Copy link
Author

Thanks @klauspost!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip AMD leaf 0x8000001d parsing if no TOPEXT klauspost/cpuid
2 participants
@klauspost @DemiMarie