Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional fixes for copyobject to handle sse-c encrypted #6

Conversation

poornas
Copy link

@poornas poornas commented Jun 12, 2024

replication

Description

Motivation and Context

Fix replication of metadata updates via CopyObject API on SSE-C encrypted objects
avoid infinite proxying on SSE-C encrypted objects

How to test this PR?

run mc replicate resync on already replicated content - will not log error on source
update tags on sse-c encrypted object - should replicate with this fix
mc cp with sse-c can lead to 429 Too many requests from infinite proxying because object options did not set opts.ProxyRequest for sse-c properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

@klauspost
Copy link
Owner

Thanks. I don't understand it, but I trust it is good :)

@klauspost klauspost merged commit b6763af into klauspost:fix-multipart-ssec-checksums Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants