Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme file box with markdown support #60

Merged
merged 4 commits into from
Jun 19, 2012
Merged

Readme file box with markdown support #60

merged 4 commits into from
Jun 19, 2012

Conversation

mprochowski
Copy link
Contributor

@mprochowski
Copy link
Contributor Author

I know that bb2k did the same functionality but with a different solution. - #59

@klaussilveira
Copy link
Owner

I'm not sure if i like rendering Markdown on the client-side. However, i have to agree that there isn't a decent Markdown renderer in PHP and Showdown is clearly well-written. What do you guys think?

@mprochowski
Copy link
Contributor Author

I checked few PHP markdown parsers and i must say that Showdown gave me the best result. I know that markdown rendering on the client-side is not good solution, but for the effect that Showdown gave, i think is worth to use it.

@bb2k
Copy link

bb2k commented Jun 19, 2012

showdown seems to have a better renderer even if i dont see any différences in my example.Anyway The mablo solution has the advantage of keeping the cache system as well

Concerning the client side parsing, i don't think the size of the readme files are enough big to decrease performances

* Show readme box for file with `readme` suffix (eg readme, readme.md. readme.txt, readme.markdown etc).
@mprochowski
Copy link
Contributor Author

@bb2k: done :)

klaussilveira added a commit that referenced this pull request Jun 19, 2012
Readme file box with markdown support
@klaussilveira klaussilveira merged commit ad67163 into klaussilveira:master Jun 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants