Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate duplicative profile key constants #150

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

evan-masseau
Copy link
Contributor

@evan-masseau evan-masseau commented Mar 25, 2024

Description

Mark these keys deprecated in advance of next major release in which we can change them to internal. They're inconsistent with iOS and duplicative of explicit setter methods anyway.

Check List

  • Are you changing anything with the public API? - YES, deprecating public constants
  • Are your changes backwards compatible with previous SDK Versions? - YES, deprecating = no change required yet.
  • Have you tested this change on real device?
  • Have you added unit test coverage for your changes? N/A
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports?

Changelog / Code Overview

Deprecate the profile keys that correspond to identifiers, which have their own setter methods.

  • TODO add new constructor so identifiers can optionally be set from constructor

Test Plan

Related Issues/Tickets

CHNL-6547

…can change them to internal

(cherry picked from commit 09152bc)
@evan-masseau evan-masseau marked this pull request as ready for review March 26, 2024 14:37
@evan-masseau evan-masseau requested a review from a team as a code owner March 26, 2024 14:37
@evan-masseau evan-masseau added the minor-release For issues/code that belong in a minor release per semantic versioning guidelines label Mar 28, 2024
README.md Show resolved Hide resolved
@evan-masseau evan-masseau added do-not-merge Indicates a pull request is not yet ready for merging and removed do-not-merge Indicates a pull request is not yet ready for merging labels Apr 3, 2024
README.md Show resolved Hide resolved
@evan-masseau evan-masseau merged commit bbbd55c into master Apr 8, 2024
2 checks passed
@evan-masseau evan-masseau deleted the ecm/CHNL-6547-deprecate-profile-keys branch April 8, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-release For issues/code that belong in a minor release per semantic versioning guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants