Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version up to 1.11.0 #371

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

JayChoi1736
Copy link
Contributor

@JayChoi1736 JayChoi1736 commented Oct 27, 2023

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@kjeom
Copy link
Contributor

kjeom commented Oct 27, 2023

@JayChoi1736 Could you double check the proposed changes with changed code?

@JayChoi1736
Copy link
Contributor Author

@JayChoi1736 Could you double check the proposed changes with changed code?

i've checked both formal caver-java PR's code and changes

@JayChoi1736 JayChoi1736 merged commit 2b0cd87 into klaytn:dev Oct 27, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants